Added Translation Standard and translation for Brazilian Portuguese#110
Merged
Added Translation Standard and translation for Brazilian Portuguese#110
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request implements Brazilian Portuguese translation by adding a new translation file and incorporating translation management commands. Sequence diagram for the new translation management processsequenceDiagram
participant Dev as Developer
participant Setup as setup.py
participant PO as .po files
participant POT as .pot file
alt Create New Translation
Dev->>Setup: Run create_translation --locale=xx
Setup->>POT: Generate/Check .pot file
Setup->>PO: Create new .po file for locale
PO-->>Dev: New translation file ready
else Update Translations
Dev->>Setup: Run update_translations
Setup->>POT: Extract messages to .pot
Setup->>PO: Update all .po files
PO-->>Dev: Updated translation files
end
Class diagram for new translation management commandsclassDiagram
class Command {
<<interface>>
+initialize_options()
+finalize_options()
+run()
}
class UpdateTranslationsCommand {
+description: string
+user_options: list
+initialize_options()
+finalize_options()
+run()
}
class CreateTranslationCommand {
+locale: string
+description: string
+user_options: list
+initialize_options()
+finalize_options()
+run()
}
Command <|-- UpdateTranslationsCommand
Command <|-- CreateTranslationCommand
note for CreateTranslationCommand "New command for creating translation files"
note for UpdateTranslationsCommand "New command for updating existing translations"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @Edu-Amorim - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please document the complete translation workflow in the README, including how to compile .mo files for use at runtime. The current documentation only shows how to create new translation files.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added translation for Brazilian Portuguese
Related to ghostbsd/issues#199
Summary by Sourcery
Add support for Brazilian Portuguese translation.
New Features:
Tests: