Conversation
Contributor
Reviewer's GuideThis PR refactors the translation update script to use a new top-level directory structure for POT and PO files, extends message merging to additional languages, and adds an initial Chinese translation template. Class diagram for translation files directory structure changesclassDiagram
class po {
zh_CN.po
fr.po
pt_br.po
ru.po
}
class pot {
update-station.pot
}
class update-station.py
po <|-- update-station.py : msgmerge
pot <|-- update-station.py : xgettext
Flow diagram for the updated translation update scriptflowchart TD
A[Copy update-station to update-station.py] --> B[Extract translatable strings with xgettext]
B --> C[Merge messages into zh_CN.po]
B --> D[Merge messages into fr.po]
B --> E[Merge messages into pt_br.po]
B --> F[Merge messages into ru.po]
C --> G[Remove update-station.py]
D --> G
E --> G
F --> G
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @alexax66 - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `update_translations.sh:7` </location>
<code_context>
+xgettext update-station.py -o pot/update-station.pot
-rm src/update-station.py
+msgmerge -U po/zh_CN.po po/update-station.pot
+msgmerge -U po/fr.po po/update-station.pot
+msgmerge -U po/pt_br.po po/update-station.pot
+msgmerge -U po/ru.po po/update-station.pot
+
+rm update-station.py
</code_context>
<issue_to_address>
The script now updates multiple language .po files, but the naming convention for 'pt_br.po' may be inconsistent.
Consider renaming 'pt_br.po' to 'pt_BR.po' for consistency and better compatibility with gettext conventions.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
msgmerge -U po/pt_br.po po/update-station.pot
=======
msgmerge -U po/pt_BR.po po/update-station.pot
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ericbsd
approved these changes
Jun 23, 2025
Member
ericbsd
left a comment
There was a problem hiding this comment.
By the way, update_translations.sh will be removed. There is a new way to create and update see the README.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Refactor the translation update workflow to use the root update-station script and new directory layout, generate the POT file under pot/, and batch-merge multiple language PO files
Enhancements: