-
Notifications
You must be signed in to change notification settings - Fork 109
add benchmark for MyoSim MyoArm #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
erikfrey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss how we want to design benchmarks going forward before we add this one. Might be time to make a few bigger changes.
| njmax = 64 | ||
|
|
||
|
|
||
| class MyoArm(benchmark.BenchmarkSuite): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this break running asv run main^! ?
Does the user have to manually run python get_myosim.py for the command above to work correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, probably need to run the script first
| _MYOSIM_COMMIT_SHA = "33f3ded946f55adbdcf963c99999587aadaf975f" | ||
|
|
||
|
|
||
| # TODO(team): shared utility with benchmark/kitchen/populate_scene._clone? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, in fact we should probably consider doing something like what playground does:
Perhaps it's time to support something like this so that we can keep these resources all outside of this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created an issue #1001 for 'resource loader'
add a benchmark for the MyoSim MyoArm musculoskeletal environment
a utility script benchmark/myosim/get_myosim.py is provided to clone MyoSim (pinned commit) from GitHub.
testspeed
note: the default
ccd_iterations(35) is too low and produces warningsairspeed velocity
todo
_clonea shared utility function?