-
Notifications
You must be signed in to change notification settings - Fork 109
improve testing for batched Model fields
#962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
394fff4 to
d5c6a14
Compare
|
@Kenny-Vilella @adenzler-nvidia is there a recommended approach for checking if any out of bounds reads occur on cpu? thanks! |
|
It will be great to have GPU runner to run compute-sanitizer. To reply to your question, I guess using valgrind should work. |
|
I'm curious why debug_mode doesn't work with CPU for you? On my machine the tests pass, they are just a lot slower. |
|
was noticing a case where to reproduce:
however, this seems to work |
|
interesting, if you use -s here you can see the assert is being printed to stderr, so in theory it works. The problem seems to be connected to the warp assert handler and how assert(false) somehow isn't being picked up by the python side properly. |
|
I found the issue, made a PR to warp. The issue is that the CPU-side assert handler calls assert(false), but that code is part of the warp library instead of the kernel code so it doesn't respect NDEBUG. |
|
nice! thanks @adenzler-nvidia |
this pr aims to improve testing for batched
Modelfields. hopefully we can prevent bugs like the ones fixed in #865, #932, #821, #819, #807, #800notes:
--debug_modedoes not work with--cpuso the changes to ci.yml will not currently work with the github actions cpu-based ci