Skip to content

Conversation

@adenzler-nvidia
Copy link
Collaborator

This PR changes the CI to use the dependency versions locked in the uv.lock file. Right now CI tests against latest dev version of warp and mujoco, which means the uv workflow is untested and we have no test for known-good dependencies.

I made this a draft because there's definitely a discussion to be had here. My stance is that we should have nightlies for dev versions of mujoco/warp and use the uv workflow for the package that ships/users will use. Like this, any change that needs a change in minimum versions should be including a version upgrade as well, and we explicitly know when we are breaking dependencies.

But I probably don't have the full picture here, so let's discuss.

Signed-off-by: Alain Denzler <adenzler@nvidia.com>
@adenzler-nvidia adenzler-nvidia marked this pull request as draft January 5, 2026 08:48
@thowell thowell requested a review from erikfrey January 5, 2026 10:57
@thowell
Copy link
Collaborator

thowell commented Jan 5, 2026

thanks @adenzler-nvidia!
#917 is probably relevant to this discussion

@thowell thowell requested a review from btaba January 5, 2026 10:59
@adenzler-nvidia
Copy link
Collaborator Author

yes, looks super relevant. Not sure if everything on this matrix needs to be tested on each PR, I think for forward compatibility it's ok to have nightlies (for uv-locked mujoco + nightly warp, or uv-locked warp and nightly mujoco).

@adenzler-nvidia
Copy link
Collaborator Author

The other thing we need (which I didn't include but we probably should) is to make sure pyproject.toml specifies correct min version that actually work. For example, the warp-lang requirement of >= 1.9.0 likely doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants