Skip to content

Conversation

@thowell
Copy link
Collaborator

@thowell thowell commented Jan 8, 2026

for hfield<>geom collisions, transform the geom pose into the hfield frame. follows the mujoco implementation https://github.com/google-deepmind/mujoco/blob/310ac0c5ac0c5fd0391b0e7ea2575314b2b4dca2/src/engine/engine_collision_convex.c#L1204

@thowell thowell changed the title transform height field prism to global frame compute collisions in height field frame Jan 8, 2026
@thowell thowell requested a review from kbayes January 8, 2026 19:58
@thowell thowell marked this pull request as ready for review January 8, 2026 21:05
@thowell thowell requested a review from kevinzakka January 8, 2026 21:05
Copy link

@louislelay louislelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @thowell and @kbayes, I just tested your changes with mjlab and it seems to have resolved our issues with hfield. Thanks for the reactivity!

@kevinzakka
Copy link
Collaborator

I just launched a job and so far, no NaNs.

@thowell thowell merged commit 4ce1c3e into google-deepmind:main Jan 9, 2026
23 checks passed
@thowell thowell linked an issue Jan 9, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review / optimize hfield performance

4 participants