BUGFIX(versioned module directory detection): differentiate between networking issues and missing go.mod#327
Open
inteon wants to merge 2 commits intogoogle:masterfrom
Open
Conversation
inteon
force-pushed
the
bugfix_versioned_module_directory
branch
2 times, most recently
from
85ad7d9 to
9d3106d
Compare
inteon
changed the title
inteon
force-pushed
the
bugfix_versioned_module_directory
branch
from
9d3106d to
bd3fae4
Compare
inteon
changed the title
inteon
force-pushed
the
bugfix_versioned_module_directory
branch
2 times, most recently
from
5fe0dfb to
0d1338e
Compare
Contributor
Author
|
@Bobgy could you take a look at this PR? |
inteon
commented
May 5, 2025
…etworking issues and go.mod being missing Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
bugfix_versioned_module_directory
branch
2 times, most recently
from
7884ca2 to
ed43e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-licenses reportin sometimes returns a different output:This was caused by a networking issue/ unstable connection that causes the go.mod retrieval to fail, resulting in the versioned module directory detection logic thinking the go.mod file does not exist.
This PR updates the logic to differentiate between networking errors and errors due to a missing go.mod.
If we encounter a networking issue, we stop go-licenses, such that the user does not unknowingly gets an invalid/ non-reproducible output.
XRef: cert-manager/cert-manager#6622