Pass upstream URL to token generation #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrepp
added a commit
to jrepp/goblet
that referenced
this pull request
Nov 7, 2025
Merges google/goblet PR #11 by @mdehoog google#11 Allows custom token generation mechanisms for different upstreams. This is useful when Goblet caches repos from different organizations where each needs its own token (e.g., GitHub app installation tokens). Changes: - Modified TokenSource from oauth2.TokenSource to a function accepting upstream URL - Updated all token generation calls to pass upstream URL parameter
This was referenced Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Goblet is used across different repos or different organizations, it's useful to support custom token generation mechanisms for different upstreams. For example, a Github app's installation tokens need to be generated separately for each organization.
This PR modifies the
TokenSourceconfiguration option to a function that accepts the upstream URL as a parameter.