Spelling #55

jsoref · 2023-10-18T10:06:26Z

This PR was rebased once to pull in recent commits (which added 3 new typos to be fixed). It's sizable, and exceeds some of GitHub's tolerances for PR sizes. I'm happy to split or do various other things to aid in ingesting changes. I will try to comment on the changes I'm proposing, but it'll take a while.

Fixes misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/google-quiche/actions/runs/6559260454#summary-17814518323

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/google-quiche/actions/runs/6559261206#summary-17814520841

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref

I'm assuming there are no downstream API consumers that would care about changes. Obviously, if there are, changes that would break them can be dropped.

Fwiw, there were a couple of instances of crypt/cryption which I had hoped could be (de|en)crypt[ion] but I didn't have the energy to determine if one or the other was correct.

jsoref · 2023-10-18T10:07:32Z

quiche/balsa/balsa_frame.h


  // If enabled, parse the available portion of headers even on a
-  // HEADERS_TOO_LONG error, so that that portion of headers is available to the
+  // HEADERS_TOO_LONG error, so that portion of headers is available to the


Sometimes that that is meaningful. In this case that portion should work just as well as that that portion even though there's technically a change in the parsing.

jsoref · 2023-10-18T10:08:06Z

quiche/balsa/balsa_frame_test.cc

      "\r\n";
  std::string message_body =
-      "A            chunkjed extension  \r\n"
+      "A             chunked extension  \r\n"


It's possible that something cares about the precise character stream, but I'm hoping there isn't.

jsoref · 2023-10-18T10:08:42Z

quiche/balsa/balsa_headers.cc

  // mistakes that the caller does not lower case the headers in keys.
  // Better performance can be achieved by asking caller to lower case
-  // the keys and RemoveAllOfheaderInlist just does lookup.
+  // the keys and RemoveAllOfheaderInList just does lookup.


There are quite a few cases where comments try to mention function names and don't get them right, you can see based on the context that this was one of them.

jsoref · 2023-10-18T10:09:35Z

quiche/balsa/balsa_headers.cc

  if (it == header_lines_.end()) {
    QUICHE_DLOG(WARNING)
-        << "Attempting to remove last token from a non-existent "
+        << "Attempting to remove last token from a nonexistent "


Happy to drop this or anything else -- in general, I group changes by the resulting spelling so if you don't like a correction, you can flag it once and I'll drop the commit.

jsoref · 2023-10-18T10:11:25Z

quiche/http2/adapter/header_validator_test.cc

  status = v.ValidateSingleHeader(
      "name2",
-      "Antidisestablishmentariansism is supercalifragilisticexpialodocious.");
+      "Antidisestablishmentariansism is supercalifragilisticexpealidocious.");


both tokens were present in this repository. There was no obvious explanation for why this incorrect spelling was present.

jsoref · 2023-10-18T10:35:57Z

quiche/quic/core/quic_stream_sequencer_buffer_test.cc

 TEST_F(QuicStreamSequencerBufferTest, ReadvAcrossBlocks) {
  std::string source(kBlockSizeBytes + 50, 'a');
-  // Write 1st block to full and extand 50 bytes to next block.
+  // Write 1st block to full and extend 50 bytes to next block.


possibly expand

jsoref · 2023-10-18T10:40:40Z

quiche/quic/core/quic_types.h

  QuicOwnedPacketBuffer(QuicOwnedPacketBuffer&& owned_buffer)
      : QuicPacketBuffer(std::move(owned_buffer)) {
-    // |owned_buffer| does not own a buffer any more.
+    // |owned_buffer| does not own a buffer anymore.


I used a heuristic which I think was right (e.g. here) more often than it was wrong (there's one place below where I got it wrong, which I'll fix after I finish leaving these notes -- sorry)
https://www.grammarly.com/blog/anymore-vs-any-more/

jsoref · 2023-10-18T10:46:01Z

quiche/quic/qbone/platform/netlink.h

  // interface_index.
  //
-  // additional_attributes are RTAs (man 7 rtnelink) that will be sent together
+  // additional_attributes are RTAs (man 7 rtnetlink) that will be sent together


sometimes there are man pages I don't recognize (especially in the network section), but this just appears to be a typo.

jsoref · 2023-10-18T10:46:53Z

quiche/quic/test_tools/crypto_test_utils.cc

    // decryption so that the crypters latch when expected. The crypters are in
    // |dest_conn|, but we don't want to try and use them there. Instead we swap
-    // them into |framer|, perform the decryption with them, and then swap ther
+    // them into |framer|, perform the decryption with them, and then swap them


Neither there nor their seemed to work, so...

jsoref · 2023-10-18T10:50:11Z

quiche/spdy/core/spdy_framer_test.cc


 // Check that the framer stops delivering header data chunks once the visitor
-// declares it doesn't want any more. This is important to guard against
+// declares it doesn't want anymore. This is important to guard against


This is wrong, sorry.

jsoref added 30 commits October 18, 2023 05:21

spelling: advertise

c418809

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: after

8119f5d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: algorithm

09dbc39

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: allowed

3d204b1

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: already

e76ed9f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: alternate

d98bddf

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: alternative

abd9911

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: among

2d38f6e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: amplification

2040f56

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: anymore

e3c7256

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: appropriate

313316c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: are

ec8abe5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: artificial

0f01fe7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: associated

300832a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: async

9546089

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: asynchronous

926506d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: attempt

e6d9669

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: b

7e42e70

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: bandwidth

a548e32

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: because

7e0a3ac

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: been

0509eaf

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: bidirectional

411a198

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: blackhole

518b09c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: boundaries

abcd5c7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: buffers

76c202f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: candidates

760ffa7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: cannot

7960641

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: canonical

d037c08

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: capacity

8861389

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: capsule

504056e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref added 28 commits October 18, 2023 06:42

spelling: terminate

158d48e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: than

8d9a2cd

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: that

bc0bbb4

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: the

d4b0ff6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: them

88b54df

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: this

0f15fae

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transferred

7eda17b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: triggers

21c71ef

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: true

2eae168

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: truncated

9e15729

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unable

a41c0c6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unavailable

b453e5c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: undecryptable

e1861bc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unidirectional

4718c5c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: uniformly

d31e7de

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unregister

f6dcac1

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unsupported

11438c9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: until

6579dd7

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: update

d16d05a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: valid

478b11f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: validation

950de3a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: verify

1859e8f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: verifying

418609a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: was

1218d73

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: whitespace

3077875

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: wildcard

3217949

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: with

8a49342

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: workaround

bc14893

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref commented Oct 18, 2023

View reviewed changes

jsoref force-pushed the spelling branch from 0c12849 to bc14893 Compare October 18, 2023 10:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Spelling #55

Spelling #55

Uh oh!

jsoref commented Oct 18, 2023

Uh oh!

jsoref left a comment

Uh oh!

jsoref Oct 18, 2023

Uh oh!

jsoref Oct 18, 2023

Uh oh!

jsoref Oct 18, 2023

Uh oh!

jsoref Oct 18, 2023

Uh oh!

jsoref Oct 18, 2023

Uh oh!

jsoref Oct 18, 2023

Uh oh!

jsoref Oct 18, 2023

Uh oh!

jsoref Oct 18, 2023

Uh oh!

jsoref Oct 18, 2023

Uh oh!

jsoref Oct 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Spelling #55

Are you sure you want to change the base?

Spelling #55

Uh oh!

Conversation

jsoref commented Oct 18, 2023

Uh oh!

jsoref left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant