Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
256 commits
Select commit Hold shift + click to select a range
c418809
spelling: advertise
jsoref Oct 17, 2023
8119f5d
spelling: after
jsoref Oct 17, 2023
09dbc39
spelling: algorithm
jsoref Oct 17, 2023
3d204b1
spelling: allowed
jsoref Oct 17, 2023
e76ed9f
spelling: already
jsoref Oct 17, 2023
d98bddf
spelling: alternate
jsoref Oct 17, 2023
abd9911
spelling: alternative
jsoref Oct 17, 2023
2d38f6e
spelling: among
jsoref Oct 17, 2023
2040f56
spelling: amplification
jsoref Oct 17, 2023
e3c7256
spelling: anymore
jsoref Oct 17, 2023
313316c
spelling: appropriate
jsoref Oct 17, 2023
ec8abe5
spelling: are
jsoref Oct 17, 2023
0f01fe7
spelling: artificial
jsoref Oct 17, 2023
300832a
spelling: associated
jsoref Oct 17, 2023
9546089
spelling: async
jsoref Oct 17, 2023
926506d
spelling: asynchronous
jsoref Oct 17, 2023
e6d9669
spelling: attempt
jsoref Oct 17, 2023
7e42e70
spelling: b
jsoref Oct 18, 2023
a548e32
spelling: bandwidth
jsoref Oct 17, 2023
7e0a3ac
spelling: because
jsoref Oct 17, 2023
0509eaf
spelling: been
jsoref Oct 17, 2023
411a198
spelling: bidirectional
jsoref Oct 17, 2023
518b09c
spelling: blackhole
jsoref Oct 17, 2023
abcd5c7
spelling: boundaries
jsoref Oct 17, 2023
76c202f
spelling: buffers
jsoref Oct 17, 2023
760ffa7
spelling: candidates
jsoref Oct 17, 2023
7960641
spelling: cannot
jsoref Oct 17, 2023
d037c08
spelling: canonical
jsoref Oct 17, 2023
8861389
spelling: capacity
jsoref Oct 17, 2023
504056e
spelling: capsule
jsoref Oct 17, 2023
8b30d1b
spelling: causing
jsoref Oct 17, 2023
bd7a625
spelling: certain
jsoref Oct 17, 2023
71e3aac
spelling: certificate
jsoref Oct 17, 2023
5e80760
spelling: challenge
jsoref Oct 17, 2023
7f6bab2
spelling: change
jsoref Oct 17, 2023
4e92ce9
spelling: chunked
jsoref Oct 18, 2023
46d3238
spelling: coalescing
jsoref Oct 17, 2023
63fcdac
spelling: completely
jsoref Oct 17, 2023
de458bb
spelling: condition
jsoref Oct 17, 2023
5f5f8c2
spelling: configurable
jsoref Oct 17, 2023
525926f
spelling: confirmed
jsoref Oct 17, 2023
b4a0558
spelling: connected
jsoref Oct 17, 2023
901d1ee
spelling: connection
jsoref Oct 17, 2023
53131a2
spelling: connectivity
jsoref Oct 17, 2023
99df69c
spelling: constructible
jsoref Oct 17, 2023
9c1ed4e
spelling: contiguous
jsoref Oct 17, 2023
a60337c
spelling: continuously
jsoref Oct 17, 2023
ef7f481
spelling: convenience
jsoref Oct 17, 2023
55e9e89
spelling: corresponding
jsoref Oct 17, 2023
d67dedb
spelling: count
jsoref Oct 17, 2023
8d2bb02
spelling: crbug
jsoref Oct 18, 2023
44ad08b
spelling: crypto
jsoref Oct 17, 2023
f96d331
spelling: cryptographic
jsoref Oct 17, 2023
e7a5c80
spelling: current
jsoref Oct 17, 2023
cfca1f1
spelling: datagram
jsoref Oct 17, 2023
e53f848
spelling: decide
jsoref Oct 17, 2023
25b4f2d
spelling: decryption
jsoref Oct 17, 2023
594298a
spelling: default
jsoref Oct 17, 2023
e109766
spelling: definitively
jsoref Oct 17, 2023
9f14a9f
spelling: degrading
jsoref Oct 17, 2023
347a8db
spelling: delayed
jsoref Oct 17, 2023
c90b7ab
spelling: delimited
jsoref Oct 17, 2023
6ce1e35
spelling: delivered
jsoref Oct 17, 2023
305317e
spelling: dependent
jsoref Oct 17, 2023
ee185a7
spelling: destination
jsoref Oct 17, 2023
2a97a99
spelling: destroyed
jsoref Oct 17, 2023
d415647
spelling: details
jsoref Oct 17, 2023
0de5918
spelling: detect
jsoref Oct 17, 2023
4a6ce24
spelling: determining
jsoref Oct 17, 2023
a312b66
spelling: different
jsoref Oct 17, 2023
cd7a1e3
spelling: differentiate
jsoref Oct 17, 2023
2df5cd1
spelling: directory
jsoref Oct 17, 2023
97fba45
spelling: disallowed
jsoref Oct 17, 2023
3eff522
spelling: discard
jsoref Oct 17, 2023
4f9020a
spelling: disconnect
jsoref Oct 17, 2023
988890f
spelling: distributed
jsoref Oct 17, 2023
8cc030d
spelling: diversification
jsoref Oct 17, 2023
39b7e6e
spelling: does
jsoref Oct 17, 2023
6b51c19
spelling: dynamic
jsoref Oct 17, 2023
1165f6e
spelling: earlier
jsoref Oct 17, 2023
9aebdf8
spelling: encapsulate
jsoref Oct 17, 2023
23faf61
spelling: encountered
jsoref Oct 17, 2023
a99c63c
spelling: encryption
jsoref Oct 17, 2023
34b676c
spelling: endianness
jsoref Oct 17, 2023
16c12e2
spelling: enough
jsoref Oct 17, 2023
b26ceb5
spelling: evicted
jsoref Oct 17, 2023
c27afe4
spelling: examine
jsoref Oct 17, 2023
38a4c15
spelling: example
jsoref Oct 17, 2023
eb34df7
spelling: excedes
jsoref Oct 17, 2023
fa23f33
spelling: exceed
jsoref Oct 17, 2023
dd37a34
spelling: exceeds
jsoref Oct 17, 2023
2f52019
spelling: exercise
jsoref Oct 17, 2023
5817fbd
spelling: existing
jsoref Oct 17, 2023
35506f0
spelling: exists
jsoref Oct 17, 2023
3e5a16c
spelling: expect
jsoref Oct 17, 2023
5eb739f
spelling: expired
jsoref Oct 17, 2023
2e27b7d
spelling: explicitly
jsoref Oct 17, 2023
42997d0
spelling: extend
jsoref Oct 17, 2023
691ab46
spelling: factory
jsoref Oct 17, 2023
0b8a8be
spelling: feature
jsoref Oct 17, 2023
1e8b4a0
spelling: firstline
jsoref Oct 17, 2023
4d03205
spelling: for
jsoref Oct 17, 2023
f1e407b
spelling: forward
jsoref Oct 17, 2023
721fc23
spelling: fragment
jsoref Oct 17, 2023
1563df7
spelling: frame
jsoref Oct 17, 2023
93acdf3
spelling: frequency
jsoref Oct 17, 2023
22c6d33
spelling: fulfill
jsoref Oct 17, 2023
07abc00
spelling: generator
jsoref Oct 17, 2023
0088f31
spelling: generic
jsoref Oct 17, 2023
575c39b
spelling: gradually
jsoref Oct 17, 2023
0e147e6
spelling: guarantee
jsoref Oct 17, 2023
56cb373
spelling: guaranteed
jsoref Oct 17, 2023
134fa23
spelling: guarantees
jsoref Oct 17, 2023
0824760
spelling: header
jsoref Oct 17, 2023
e0a191d
spelling: hello
jsoref Oct 17, 2023
9751865
spelling: identify
jsoref Oct 17, 2023
ffe87c6
spelling: immediately
jsoref Oct 17, 2023
6f7a1a6
spelling: implementation
jsoref Oct 17, 2023
c3c6450
spelling: implemented
jsoref Oct 17, 2023
d81311e
spelling: implements
jsoref Oct 17, 2023
c242f2c
spelling: in-list
jsoref Oct 18, 2023
5cb43b3
spelling: incorrect
jsoref Oct 17, 2023
813aac4
spelling: increase
jsoref Oct 18, 2023
4b7c133
spelling: increases
jsoref Oct 17, 2023
0d23c5c
spelling: increments
jsoref Oct 17, 2023
d9b761a
spelling: initialize
jsoref Oct 18, 2023
6d4af16
spelling: initialized
jsoref Oct 17, 2023
c6802f6
spelling: initiate
jsoref Oct 17, 2023
e774f39
spelling: initiates
jsoref Oct 17, 2023
b7600de
spelling: initiating
jsoref Oct 17, 2023
e0e53c4
spelling: instantaneously
jsoref Oct 17, 2023
33dc95c
spelling: instigate
jsoref Oct 18, 2023
92c2584
spelling: interface
jsoref Oct 17, 2023
f7c5068
spelling: interval
jsoref Oct 17, 2023
b394402
spelling: into
jsoref Oct 17, 2023
f32ebdc
spelling: invalid
jsoref Oct 17, 2023
dc6d09b
spelling: isn't
jsoref Oct 17, 2023
dfcb344
spelling: iterator
jsoref Oct 18, 2023
0fa5a5a
spelling: language
jsoref Oct 17, 2023
34a5ebb
spelling: least
jsoref Oct 18, 2023
28feba4
spelling: length
jsoref Oct 17, 2023
2735386
spelling: limiting
jsoref Oct 18, 2023
d89b262
spelling: literal
jsoref Oct 17, 2023
19563cf
spelling: lost
jsoref Oct 18, 2023
83144a3
spelling: maximum
jsoref Oct 17, 2023
75884f2
spelling: message
jsoref Oct 17, 2023
8ede459
spelling: minimum
jsoref Oct 18, 2023
847370e
spelling: multiple
jsoref Oct 18, 2023
8b90e79
spelling: necessary
jsoref Oct 18, 2023
8824280
spelling: neither
jsoref Oct 17, 2023
bbda60c
spelling: nonexistent
jsoref Oct 17, 2023
e3b53f0
spelling: notified
jsoref Oct 17, 2023
ada9758
spelling: notifier
jsoref Oct 18, 2023
cc07ff0
spelling: number
jsoref Oct 18, 2023
d2df419
spelling: observation
jsoref Oct 17, 2023
c774266
spelling: occurring
jsoref Oct 17, 2023
af796d3
spelling: order
jsoref Oct 18, 2023
488641b
spelling: outgoing
jsoref Oct 17, 2023
5363dc5
spelling: packets
jsoref Oct 17, 2023
f22a27d
spelling: padding
jsoref Oct 17, 2023
1bbe7ec
spelling: parameter
jsoref Oct 17, 2023
f16c7e2
spelling: parameters
jsoref Oct 17, 2023
2db2f09
spelling: parsable
jsoref Oct 18, 2023
0b5fd6c
spelling: partitions
jsoref Oct 18, 2023
12d2e14
spelling: pending
jsoref Oct 18, 2023
e81bf5c
spelling: performance
jsoref Oct 17, 2023
f1f0a04
spelling: physically
jsoref Oct 17, 2023
bc5c8bd
spelling: popped
jsoref Oct 17, 2023
28a0e32
spelling: populate
jsoref Oct 18, 2023
b6a3a01
spelling: potentially
jsoref Oct 18, 2023
0cb28af
spelling: precede
jsoref Oct 18, 2023
8ff9f79
spelling: preceded
jsoref Oct 17, 2023
e6f23ae
spelling: preferred
jsoref Oct 18, 2023
febaa82
spelling: priority
jsoref Oct 17, 2023
7ea4957
spelling: procedure
jsoref Oct 17, 2023
e5f40b6
spelling: process
jsoref Oct 18, 2023
96af5d8
spelling: processed
jsoref Oct 17, 2023
33a6c1a
spelling: processing
jsoref Oct 18, 2023
6fe89e0
spelling: progressive
jsoref Oct 18, 2023
e09aa0d
spelling: quiescence
jsoref Oct 18, 2023
a0a2a70
spelling: receipt
jsoref Oct 18, 2023
d61dd70
spelling: receive
jsoref Oct 18, 2023
f75aaf3
spelling: received
jsoref Oct 17, 2023
08acbb0
spelling: receiving
jsoref Oct 17, 2023
8ad4f5e
spelling: reentrancy
jsoref Oct 17, 2023
18e1f4e
spelling: reentrant
jsoref Oct 17, 2023
7c4fe17
spelling: regression
jsoref Oct 18, 2023
fd990b4
spelling: reordering
jsoref Oct 18, 2023
89b0a30
spelling: required
jsoref Oct 18, 2023
c9b84cf
spelling: reserializes
jsoref Oct 18, 2023
d73ac26
spelling: responsible
jsoref Oct 17, 2023
c7bb06a
spelling: retransmissibility
jsoref Oct 18, 2023
c4db47f
spelling: retransmissible
jsoref Oct 17, 2023
cb7fbc8
spelling: retransmissions
jsoref Oct 17, 2023
b196f2f
spelling: retransmitted
jsoref Oct 18, 2023
0ac1f8c
spelling: retryable
jsoref Oct 17, 2023
4db7f4b
spelling: rtnetlink
jsoref Oct 18, 2023
2748a3c
spelling: sanitizer
jsoref Oct 17, 2023
7d17833
spelling: second
jsoref Oct 18, 2023
06ab1a1
spelling: separately
jsoref Oct 18, 2023
1041ad7
spelling: sequencer
jsoref Oct 17, 2023
e8ee1e3
spelling: serialization
jsoref Oct 17, 2023
c203954
spelling: serialize
jsoref Oct 18, 2023
24e7815
spelling: serialized
jsoref Oct 17, 2023
7b411dc
spelling: servers
jsoref Oct 17, 2023
143cb0d
spelling: should
jsoref Oct 18, 2023
25029e7
spelling: shouldn't
jsoref Oct 18, 2023
441e40c
spelling: simulate
jsoref Oct 18, 2023
bf1bbe4
spelling: simultaneous
jsoref Oct 18, 2023
ff2ecc8
spelling: small
jsoref Oct 18, 2023
afa0936
spelling: source
jsoref Oct 18, 2023
2795c2a
spelling: specified
jsoref Oct 17, 2023
52aa7f8
spelling: storage
jsoref Oct 17, 2023
779fc86
spelling: strategy
jsoref Oct 17, 2023
d198994
spelling: stream
jsoref Oct 17, 2023
6ac55c7
spelling: subsequently
jsoref Oct 17, 2023
1a2a9a8
spelling: succeeds
jsoref Oct 18, 2023
3f7f0b6
spelling: successfully
jsoref Oct 17, 2023
c34714a
spelling: supercalifragilisticexpealidocious
jsoref Oct 18, 2023
9714703
spelling: switches
jsoref Oct 18, 2023
fad4678
spelling: synthesized
jsoref Oct 18, 2023
2523d1a
spelling: techniques
jsoref Oct 17, 2023
158d48e
spelling: terminate
jsoref Oct 18, 2023
8d9a2cd
spelling: than
jsoref Oct 17, 2023
bc0bbb4
spelling: that
jsoref Oct 17, 2023
d4b0ff6
spelling: the
jsoref Oct 17, 2023
88b54df
spelling: them
jsoref Oct 18, 2023
0f15fae
spelling: this
jsoref Oct 17, 2023
7eda17b
spelling: transferred
jsoref Oct 18, 2023
21c71ef
spelling: triggers
jsoref Oct 18, 2023
2eae168
spelling: true
jsoref Oct 17, 2023
9e15729
spelling: truncated
jsoref Oct 18, 2023
a41c0c6
spelling: unable
jsoref Oct 17, 2023
b453e5c
spelling: unavailable
jsoref Oct 17, 2023
e1861bc
spelling: undecryptable
jsoref Oct 18, 2023
4718c5c
spelling: unidirectional
jsoref Oct 17, 2023
d31e7de
spelling: uniformly
jsoref Oct 18, 2023
f6dcac1
spelling: unregister
jsoref Oct 18, 2023
11438c9
spelling: unsupported
jsoref Oct 18, 2023
6579dd7
spelling: until
jsoref Oct 18, 2023
d16d05a
spelling: update
jsoref Oct 17, 2023
478b11f
spelling: valid
jsoref Oct 18, 2023
950de3a
spelling: validation
jsoref Oct 18, 2023
1859e8f
spelling: verify
jsoref Oct 18, 2023
418609a
spelling: verifying
jsoref Oct 17, 2023
1218d73
spelling: was
jsoref Oct 17, 2023
3077875
spelling: whitespace
jsoref Oct 17, 2023
3217949
spelling: wildcard
jsoref Oct 17, 2023
8a49342
spelling: with
jsoref Oct 18, 2023
bc14893
spelling: workaround
jsoref Oct 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion depstool/deps/parse_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ http_archive(
LastUpdated: "2022-05-18",
}
if !reflect.DeepEqual(*deps, expected) {
t.Errorf("Parsing returned incorret result, expected:\n %v\n, got:\n %v", expected, *deps)
t.Errorf("Parsing returned incorrect result, expected:\n %v\n, got:\n %v", expected, *deps)
}
}

Expand Down
2 changes: 1 addition & 1 deletion quiche/balsa/balsa_frame.h
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ class QUICHE_EXPORT BalsaFrame : public FramerInterface {
}

// If enabled, parse the available portion of headers even on a
// HEADERS_TOO_LONG error, so that that portion of headers is available to the
// HEADERS_TOO_LONG error, so that portion of headers is available to the
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes that that is meaningful. In this case that portion should work just as well as that that portion even though there's technically a change in the parsing.

// error handler. Generally results in the last header being truncated.
void set_parse_truncated_headers_even_when_headers_too_long(bool set) {
parse_truncated_headers_even_when_headers_too_long_ = set;
Expand Down
16 changes: 8 additions & 8 deletions quiche/balsa/balsa_frame_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1709,7 +1709,7 @@ TEST_F(HTTPBalsaFrameTest,
"trAnsfer-eNcoding: chunked\r\n"
"\r\n";
std::string message_body =
"A chunkjed extension \r\n"
"A chunked extension \r\n"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible that something cares about the precise character stream, but I'm hoping there isn't.

"01234567890 more crud including numbers 123123\r\n"
"3f\n"
"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n"
Expand All @@ -1734,7 +1734,7 @@ TEST_F(HTTPBalsaFrameTest,
EXPECT_CALL(visitor_mock_, HeaderDone());
EXPECT_CALL(visitor_mock_, OnChunkLength(10));
EXPECT_CALL(visitor_mock_,
OnChunkExtensionInput(" chunkjed extension "));
OnChunkExtensionInput(" chunked extension "));
EXPECT_CALL(visitor_mock_, OnChunkLength(63));
EXPECT_CALL(visitor_mock_, OnChunkExtensionInput(""));
EXPECT_CALL(visitor_mock_, OnChunkLength(0));
Expand Down Expand Up @@ -1777,7 +1777,7 @@ TEST_P(HTTPBalsaFrameWithTrailersTest,
" \t includes a continuation\n"
"\r\n";
std::string message_body =
"A chunkjed extension \r\n"
"A chunked extension \r\n"
"01234567890 more crud including numbers 123123\r\n"
"3f\n"
"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n"
Expand Down Expand Up @@ -2192,7 +2192,7 @@ TEST_F(HTTPBalsaFrameTest,
"trAnsfer-eNcoding: chunked\r\n"
"\r\n";
std::string message_body =
"A chunkjed extension \r\n"
"A chunked extension \r\n"
"01234567890 more crud including numbers 123123\r\n"
"3f\n"
"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n"
Expand Down Expand Up @@ -2254,7 +2254,7 @@ TEST_P(HTTPBalsaFrameWithTrailersTest,
"trAnsfer-eNcoding: chunked\r\n"
"\r\n";
std::string message_body =
"A chunkjed extension \r\n"
"A chunked extension \r\n"
"01234567890 more crud including numbers 123123\r\n"
"3f\n"
"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n"
Expand Down Expand Up @@ -2331,7 +2331,7 @@ TEST_P(
"trAnsfer-eNcoding: chunked\r\n"
"\r\n";
std::string message_body =
"A chunkjed extension \r\n"
"A chunked extension \r\n"
"01234567890 more crud including numbers 123123\r\n"
"3f\n"
"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n"
Expand Down Expand Up @@ -2414,7 +2414,7 @@ TEST(HTTPBalsaFrame,
"trAnsfer-eNcoding: chunked\r\n"
"\r\n";
std::string message_body =
"A chunkjed extension \r\n"
"A chunked extension \r\n"
"01234567890 more crud including numbers 123123\r\n"
"3f\n"
"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n"
Expand Down Expand Up @@ -2510,7 +2510,7 @@ TEST(
"trAnsfer-eNcoding: chunked\r\n"
"\r\n";
std::string message_body =
"A chunkjed extension \r\n"
"A chunked extension \r\n"
"01234567890 more crud including numbers 123123\r\n"
"3f\n"
"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n"
Expand Down
6 changes: 3 additions & 3 deletions quiche/balsa/balsa_headers.cc
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ void BalsaHeaders::ParseTokenList(absl::string_view header_value,
// found. marked.
const char* nws = start;

// search for next whitspace or separator char.
// search for next whitespace or separator char.
while (*start != ',' && static_cast<unsigned char>(*start) > ' ') {
++start;
if (start == end) {
Expand Down Expand Up @@ -625,7 +625,7 @@ void BalsaHeaders::RemoveAllOfHeaderInList(const HeaderTokenList& keys) {
// This extra copy sacrifices some performance to prevent the possible
// mistakes that the caller does not lower case the headers in keys.
// Better performance can be achieved by asking caller to lower case
// the keys and RemoveAllOfheaderInlist just does lookup.
// the keys and RemoveAllOfheaderInList just does lookup.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few cases where comments try to mention function names and don't get them right, you can see based on the context that this was one of them.

absl::flat_hash_set<std::string> lowercase_keys;
for (const auto& key : keys) {
MaybeClearSpecialHeaderValues(key);
Expand Down Expand Up @@ -1102,7 +1102,7 @@ void BalsaHeaders::RemoveLastTokenFromHeaderValue(absl::string_view key) {
GetHeaderLinesIterator(key, header_lines_.begin());
if (it == header_lines_.end()) {
QUICHE_DLOG(WARNING)
<< "Attempting to remove last token from a non-existent "
<< "Attempting to remove last token from a nonexistent "
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to drop this or anything else -- in general, I group changes by the resulting spelling so if you don't like a correction, you can flag it once and I'll drop the commit.

<< "header \"" << key << "\"";
return;
}
Expand Down
2 changes: 1 addition & 1 deletion quiche/balsa/balsa_headers.h
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,7 @@ class QUICHE_EXPORT BalsaHeaders : public HeaderApi {

absl::string_view response_code() const override {
// Note: There is no difference between request_uri() and response_code().
// They both could be called GetSecondtTokenFromFirstline(), but, as noted
// They both could be called GetSecondTokenFromFirstline(), but, as noted
// in an earlier comment, that wouldn't be as descriptive.
return request_uri();
}
Expand Down
10 changes: 5 additions & 5 deletions quiche/balsa/balsa_headers_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2450,7 +2450,7 @@ TEST(BalsaHeaders,
SCOPED_TRACE(
"This test tests the codepath where the new firstline is"
" too large to fit within the space used by the original"
" firstline, but large enuogh to space in the free space"
" firstline, but large enough to space in the free space"
" available in both firstline plus the space made available"
" with deleted header lines (specifically, the first one");
BalsaHeaders headers = CreateHTTPHeaders(
Expand Down Expand Up @@ -2523,7 +2523,7 @@ TEST(BalsaHeaders, TestSettingMissingFirstlineElementsAfterBalsaHeadersParsed) {
}
}

// Here we exersize the codepaths involved in setting a new firstine when the
// Here we exercise the codepaths involved in setting a new firstline when the
// previously set firstline is stored in the 'additional_data_stream_'
// variable, and the new firstline is larger than the previously set firstline.
TEST(BalsaHeaders,
Expand All @@ -2549,7 +2549,7 @@ TEST(BalsaHeaders,
StrEq("HTTP/1.10 2000 REALLY don't need a reason"));
}

// Here we exersize the codepaths involved in setting a new firstine when the
// Here we exercise the codepaths involved in setting a new firstline when the
// previously set firstline is stored in the 'additional_data_stream_'
// variable, and the new firstline is smaller than the previously set firstline.
TEST(BalsaHeaders,
Expand Down Expand Up @@ -3041,7 +3041,7 @@ TEST(BalsaHeaders, TestAppendToHeaderWithCommaAndSpace) {
}

TEST(BalsaHeaders, TestInitialAppendWithCommaAndSpace) {
// Test that AppendToHeadeWithCommaAndSpace works properly when the
// Test that AppendToHeaderWithCommaAndSpace works properly when the
// header did not already exist.
BalsaHeaders headers;
headers.AppendToHeaderWithCommaAndSpace("foo", "foo_value");
Expand All @@ -3051,7 +3051,7 @@ TEST(BalsaHeaders, TestInitialAppendWithCommaAndSpace) {
}

TEST(BalsaHeaders, TestAppendWithCommaAndSpaceAndRemove) {
// Test that AppendToHeadeWithCommaAndSpace works properly with removing.
// Test that AppendToHeaderWithCommaAndSpace works properly with removing.
BalsaHeaders headers;
headers.AppendToHeaderWithCommaAndSpace("foo", "foo_value");
EXPECT_THAT(headers.GetHeader("foo"), StrEq("foo_value"));
Expand Down
2 changes: 1 addition & 1 deletion quiche/blind_sign_auth/proto/auth_and_sign.proto
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,6 @@ message AuthAndSignResponse {
// users in the format of "${Region}.${timestamp}.${signature}".
string region_token_and_signature = 6;

// The APN type bridge-proxy use to deside which APN to use for connecting.
// The APN type bridge-proxy use to decide which APN to use for connecting.
string apn_type = 7;
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ inline std::unique_ptr<quic::ProofVerifier> CreateDefaultProofVerifier(
}

// Provides a default proof source for CLI-based tools. The actual certificates
// used in the proof source should be confifgurable via command-line flags.
// used in the proof source should be configurable via command-line flags.
inline std::unique_ptr<quic::ProofSource> CreateDefaultProofSource() {
return CreateDefaultProofSourceImpl();
}
Expand Down
2 changes: 1 addition & 1 deletion quiche/common/platform/api/quiche_server_stats.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ namespace quiche {

// Sample usage:
// QUICHE_SERVER_SERVER_HISTOGRAM_CUSTOM_COUNTS("My.Histogram", 1, 100000000,
// 100, "Counters of hitting certian code.");
// 100, "Counters of hitting certain code.");

#define QUICHE_SERVER_HISTOGRAM_COUNTS(name, sample, min, max, bucket_count, \
docstring) \
Expand Down
2 changes: 1 addition & 1 deletion quiche/common/platform/api/quiche_url_utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace quiche {

// Produces concrete URLs in |target| from templated ones in |uri_template|.
// Parameters are URL-encoded. Collects the names of any expanded variables in
// |vars_found|. Returns true if the template was parseable, false if it was
// |vars_found|. Returns true if the template was parsable, false if it was
// malformed.
inline bool ExpandURITemplate(
const std::string& uri_template,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace quiche {
// Produces concrete URLs in |target| from templated ones in |uri_template|.
// Parameters are URL-encoded. Collects the names of any expanded variables in
// |vars_found|. Supports level 1 templates as specified in RFC 6570. Returns
// true if the template was parseable, false if it was malformed.
// true if the template was parsable, false if it was malformed.
QUICHE_EXPORT bool ExpandURITemplateImpl(
const std::string& uri_template,
const absl::flat_hash_map<std::string, std::string>& parameters,
Expand Down
4 changes: 2 additions & 2 deletions quiche/common/quiche_circular_deque.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ namespace quiche {
// all elements. At any point in time, either
// a) All elements are placed in a contiguous portion of this buffer, like a
// c-array, or
// b) Elements are phycially divided into two parts: the first part occupies the
// b) Elements are physically divided into two parts: the first part occupies the
// end of the buffer and the second part occupies the beginning of the
// buffer.
//
// Currently, elements can only be pushed or poped from either ends, it can't be
// Currently, elements can only be pushed or popped from either ends, it can't be
// inserted or erased in the middle.
//
// TODO(wub): Make memory grow/shrink strategies customizable.
Expand Down
2 changes: 1 addition & 1 deletion quiche/common/quiche_data_writer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ bool QuicheDataWriter::WriteVarInt62(uint64_t value) {
}
return false;
}
// Can not encode, high 2 bits not 0
// Cannot encode, high 2 bits not 0
return false;
}

Expand Down
2 changes: 1 addition & 1 deletion quiche/common/quiche_ip_address_family.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

namespace quiche {

// IP address family type used in QUIC. This hides platform dependant IP address
// IP address family type used in QUIC. This hides platform dependent IP address
// family types.
enum class IpAddressFamily {
IP_V4,
Expand Down
2 changes: 1 addition & 1 deletion quiche/common/structured_headers_generated_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const struct ParameterizedItemTestCase {
2,
{{Item("", Item::kByteSequenceType), {}}},
nullptr},
{"bad paddding",
{"bad padding",
":aGVsbG8:",
9,
{{Item("hello", Item::kByteSequenceType), {}}},
Expand Down
6 changes: 3 additions & 3 deletions quiche/common/structured_headers_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ const ItemTestCase sh09_item_test_cases[] = {
{"basic binary", "*aGVsbG8=*", Item("hello", Item::kByteSequenceType),
nullptr},
{"empty binary", "**", Item("", Item::kByteSequenceType), nullptr},
{"bad paddding", "*aGVsbG8*", Item("hello", Item::kByteSequenceType),
{"bad padding", "*aGVsbG8*", Item("hello", Item::kByteSequenceType),
"*aGVsbG8=*"},
{"bad end delimiter", "*aGVsbG8=", absl::nullopt, nullptr},
{"extra whitespace", "*aGVsb G8=*", absl::nullopt, nullptr},
Expand Down Expand Up @@ -581,8 +581,8 @@ TEST(StructuredHeaderTest, UnserializableDecimals) {

// These values cannot be directly parsed from headers, but are valid doubles
// which can be serialized as sh-floats (though rounding is expected.)
TEST(StructuredHeaderTest, SerializeUnparseableDecimals) {
struct UnparseableDecimal {
TEST(StructuredHeaderTest, SerializeUnparsableDecimals) {
struct UnparsableDecimal {
const char* name;
double value;
const char* canonical;
Expand Down
2 changes: 1 addition & 1 deletion quiche/http2/adapter/adapter_impl_comparison_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ TEST(AdapterImplComparisonTest, ClientHandlesFrames) {
oghttp2_visitor.GetEventSequence());

// TODO(b/181586191): Consider consistent behavior for delivering events on
// non-existent streams between nghttp2_adapter and oghttp2_adapter.
// nonexistent streams between nghttp2_adapter and oghttp2_adapter.
}

TEST(AdapterImplComparisonTest, SubmitWindowUpdateBumpsWindow) {
Expand Down
4 changes: 2 additions & 2 deletions quiche/http2/adapter/header_validator_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ TEST(HeaderValidatorTest, ExceedsMaxSize) {
EXPECT_EQ(HeaderValidator::HEADER_OK, status);
status = v.ValidateSingleHeader(
"name2",
"Antidisestablishmentariansism is supercalifragilisticexpialodocious.");
"Antidisestablishmentariansism is supercalifragilisticexpealidocious.");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both tokens were present in this repository. There was no obvious explanation for why this incorrect spelling was present.

EXPECT_EQ(HeaderValidator::HEADER_FIELD_TOO_LONG, status);
}

Expand Down Expand Up @@ -432,7 +432,7 @@ TEST(HeaderValidatorTest, WebsocketPseudoHeaders) {
}
EXPECT_EQ(HeaderValidator::HEADER_OK,
v.ValidateSingleHeader(":protocol", "websocket"));
// After allowing the method, `:protocol` is acepted for CONNECT requests.
// After allowing the method, `:protocol` is accepted for CONNECT requests.
EXPECT_TRUE(v.FinishHeaderBlock(HeaderType::REQUEST));
}

Expand Down
2 changes: 1 addition & 1 deletion quiche/http2/adapter/mock_http2_visitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class QUICHE_NO_EXPORT MockHttp2Visitor : public Http2VisitorInterface {
(override));

MOCK_METHOD(bool, OnDataPaddingLength,
(Http2StreamId strema_id, size_t padding_length), (override));
(Http2StreamId stream_id, size_t padding_length), (override));

MOCK_METHOD(bool, OnBeginDataForStream,
(Http2StreamId stream_id, size_t payload_length), (override));
Expand Down
2 changes: 1 addition & 1 deletion quiche/http2/adapter/nghttp2_adapter_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ TEST(NgHttp2AdapterTest, ClientHandlesFrames) {
// Should be 3, but this method only works for server adapters.
EXPECT_EQ(0, adapter->GetHighestReceivedStreamId());

// Even though the client recieved a GOAWAY, streams 1 and 5 are still active.
// Even though the client received a GOAWAY, streams 1 and 5 are still active.
EXPECT_TRUE(adapter->want_read());

EXPECT_CALL(visitor, OnFrameHeader(1, 0, DATA, 1));
Expand Down
2 changes: 1 addition & 1 deletion quiche/http2/adapter/nghttp2_session_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ TEST_F(NgHttp2SessionTest, ClientHandlesFrames) {
const int64_t stream_result = session.ProcessBytes(stream_frames);
EXPECT_EQ(stream_frames.size(), stream_result);

// Even though the client recieved a GOAWAY, streams 1 and 5 are still active.
// Even though the client received a GOAWAY, streams 1 and 5 are still active.
EXPECT_TRUE(session.want_read());

EXPECT_CALL(visitor_, OnFrameHeader(1, 0, DATA, 1));
Expand Down
4 changes: 2 additions & 2 deletions quiche/http2/adapter/noop_header_validator_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ TEST(NoopHeaderValidatorTest, ExceedsMaxSize) {
EXPECT_EQ(NoopHeaderValidator::HEADER_OK, status);
status = v.ValidateSingleHeader(
"name2",
"Antidisestablishmentariansism is supercalifragilisticexpialodocious.");
"Antidisestablishmentariansism is supercalifragilisticexpealidocious.");
EXPECT_EQ(NoopHeaderValidator::HEADER_OK, status);
}

Expand Down Expand Up @@ -227,7 +227,7 @@ TEST(NoopHeaderValidatorTest, WebsocketPseudoHeaders) {
}
EXPECT_EQ(NoopHeaderValidator::HEADER_OK,
v.ValidateSingleHeader(":protocol", "websocket"));
// After allowing the method, `:protocol` is acepted for CONNECT requests.
// After allowing the method, `:protocol` is accepted for CONNECT requests.
EXPECT_TRUE(v.FinishHeaderBlock(HeaderType::REQUEST));
}

Expand Down
6 changes: 3 additions & 3 deletions quiche/http2/adapter/oghttp2_session.cc
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const int kSendError = -902;

constexpr absl::string_view kHeadValue = "HEAD";

// TODO(birenroy): Consider incorporating spdy::FlagsSerializionVisitor here.
// TODO(birenroy): Consider incorporating spdy::FlagsSerializationVisitor here.
class FrameAttributeCollector : public spdy::SpdyFrameVisitor {
public:
FrameAttributeCollector() = default;
Expand Down Expand Up @@ -1158,7 +1158,7 @@ void OgHttp2Session::OnStreamPadLength(spdy::SpdyStreamId stream_id,
void OgHttp2Session::OnStreamPadding(spdy::SpdyStreamId /*stream_id*/, size_t
/*len*/) {
// Flow control was accounted for in OnStreamPadLength().
// TODO(181586191): Pass padding to the visitor?
// TODO(b/181586191): Pass padding to the visitor?
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the other instances for this TODO...

}

spdy::SpdyHeadersHandlerInterface* OgHttp2Session::OnHeaderFrameStart(
Expand Down Expand Up @@ -1473,7 +1473,7 @@ void OgHttp2Session::OnWindowUpdate(spdy::SpdyStreamId stream_id,
LatchErrorAndNotify(Http2ErrorCode::PROTOCOL_ERROR,
ConnectionError::kWrongFrameSequence);
}
// Do not inform the visitor of a WINDOW_UPDATE for a non-existent stream.
// Do not inform the visitor of a WINDOW_UPDATE for a nonexistent stream.
return;
} else {
if (streams_reset_.contains(stream_id)) {
Expand Down
2 changes: 1 addition & 1 deletion quiche/http2/adapter/oghttp2_session.h
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ class QUICHE_EXPORT OgHttp2Session : public Http2Session,
};
using ProcessBytesResult = absl::variant<int64_t, ProcessBytesError>;

// Attempts to process `bytes` and returns the number of bytes proccessed on
// Attempts to process `bytes` and returns the number of bytes processed on
// success or the processing error on failure.
ProcessBytesResult ProcessBytesImpl(absl::string_view bytes);

Expand Down
Loading