-
Notifications
You must be signed in to change notification settings - Fork 162
Spelling #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Spelling #55
Changes from all commits
c418809
8119f5d
09dbc39
3d204b1
e76ed9f
d98bddf
abd9911
2d38f6e
2040f56
e3c7256
313316c
ec8abe5
0f01fe7
300832a
9546089
926506d
e6d9669
7e42e70
a548e32
7e0a3ac
0509eaf
411a198
518b09c
abcd5c7
76c202f
760ffa7
7960641
d037c08
8861389
504056e
8b30d1b
bd7a625
71e3aac
5e80760
7f6bab2
4e92ce9
46d3238
63fcdac
de458bb
5f5f8c2
525926f
b4a0558
901d1ee
53131a2
99df69c
9c1ed4e
a60337c
ef7f481
55e9e89
d67dedb
8d2bb02
44ad08b
f96d331
e7a5c80
cfca1f1
e53f848
25b4f2d
594298a
e109766
9f14a9f
347a8db
c90b7ab
6ce1e35
305317e
ee185a7
2a97a99
d415647
0de5918
4a6ce24
a312b66
cd7a1e3
2df5cd1
97fba45
3eff522
4f9020a
988890f
8cc030d
39b7e6e
6b51c19
1165f6e
9aebdf8
23faf61
a99c63c
34b676c
16c12e2
b26ceb5
c27afe4
38a4c15
eb34df7
fa23f33
dd37a34
2f52019
5817fbd
35506f0
3e5a16c
5eb739f
2e27b7d
42997d0
691ab46
0b8a8be
1e8b4a0
4d03205
f1e407b
721fc23
1563df7
93acdf3
22c6d33
07abc00
0088f31
575c39b
0e147e6
56cb373
134fa23
0824760
e0a191d
9751865
ffe87c6
6f7a1a6
c3c6450
d81311e
c242f2c
5cb43b3
813aac4
4b7c133
0d23c5c
d9b761a
6d4af16
c6802f6
e774f39
b7600de
e0e53c4
33dc95c
92c2584
f7c5068
b394402
f32ebdc
dc6d09b
dfcb344
0fa5a5a
34a5ebb
28feba4
2735386
d89b262
19563cf
83144a3
75884f2
8ede459
847370e
8b90e79
8824280
bbda60c
e3b53f0
ada9758
cc07ff0
d2df419
c774266
af796d3
488641b
5363dc5
f22a27d
1bbe7ec
f16c7e2
2db2f09
0b5fd6c
12d2e14
e81bf5c
f1f0a04
bc5c8bd
28a0e32
b6a3a01
0cb28af
8ff9f79
e6f23ae
febaa82
7ea4957
e5f40b6
96af5d8
33a6c1a
6fe89e0
e09aa0d
a0a2a70
d61dd70
f75aaf3
08acbb0
8ad4f5e
18e1f4e
7c4fe17
fd990b4
89b0a30
c9b84cf
d73ac26
c7bb06a
c4db47f
cb7fbc8
b196f2f
0ac1f8c
4db7f4b
2748a3c
7d17833
06ab1a1
1041ad7
e8ee1e3
c203954
24e7815
7b411dc
143cb0d
25029e7
441e40c
bf1bbe4
ff2ecc8
afa0936
2795c2a
52aa7f8
779fc86
d198994
6ac55c7
1a2a9a8
3f7f0b6
c34714a
9714703
fad4678
2523d1a
158d48e
8d9a2cd
bc0bbb4
d4b0ff6
88b54df
0f15fae
7eda17b
21c71ef
2eae168
9e15729
a41c0c6
b453e5c
e1861bc
4718c5c
d31e7de
f6dcac1
11438c9
6579dd7
d16d05a
478b11f
950de3a
1859e8f
418609a
1218d73
3077875
3217949
8a49342
bc14893
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1709,7 +1709,7 @@ TEST_F(HTTPBalsaFrameTest, | |
| "trAnsfer-eNcoding: chunked\r\n" | ||
| "\r\n"; | ||
| std::string message_body = | ||
| "A chunkjed extension \r\n" | ||
| "A chunked extension \r\n" | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's possible that something cares about the precise character stream, but I'm hoping there isn't. |
||
| "01234567890 more crud including numbers 123123\r\n" | ||
| "3f\n" | ||
| "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n" | ||
|
|
@@ -1734,7 +1734,7 @@ TEST_F(HTTPBalsaFrameTest, | |
| EXPECT_CALL(visitor_mock_, HeaderDone()); | ||
| EXPECT_CALL(visitor_mock_, OnChunkLength(10)); | ||
| EXPECT_CALL(visitor_mock_, | ||
| OnChunkExtensionInput(" chunkjed extension ")); | ||
| OnChunkExtensionInput(" chunked extension ")); | ||
| EXPECT_CALL(visitor_mock_, OnChunkLength(63)); | ||
| EXPECT_CALL(visitor_mock_, OnChunkExtensionInput("")); | ||
| EXPECT_CALL(visitor_mock_, OnChunkLength(0)); | ||
|
|
@@ -1777,7 +1777,7 @@ TEST_P(HTTPBalsaFrameWithTrailersTest, | |
| " \t includes a continuation\n" | ||
| "\r\n"; | ||
| std::string message_body = | ||
| "A chunkjed extension \r\n" | ||
| "A chunked extension \r\n" | ||
| "01234567890 more crud including numbers 123123\r\n" | ||
| "3f\n" | ||
| "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n" | ||
|
|
@@ -2192,7 +2192,7 @@ TEST_F(HTTPBalsaFrameTest, | |
| "trAnsfer-eNcoding: chunked\r\n" | ||
| "\r\n"; | ||
| std::string message_body = | ||
| "A chunkjed extension \r\n" | ||
| "A chunked extension \r\n" | ||
| "01234567890 more crud including numbers 123123\r\n" | ||
| "3f\n" | ||
| "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n" | ||
|
|
@@ -2254,7 +2254,7 @@ TEST_P(HTTPBalsaFrameWithTrailersTest, | |
| "trAnsfer-eNcoding: chunked\r\n" | ||
| "\r\n"; | ||
| std::string message_body = | ||
| "A chunkjed extension \r\n" | ||
| "A chunked extension \r\n" | ||
| "01234567890 more crud including numbers 123123\r\n" | ||
| "3f\n" | ||
| "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n" | ||
|
|
@@ -2331,7 +2331,7 @@ TEST_P( | |
| "trAnsfer-eNcoding: chunked\r\n" | ||
| "\r\n"; | ||
| std::string message_body = | ||
| "A chunkjed extension \r\n" | ||
| "A chunked extension \r\n" | ||
| "01234567890 more crud including numbers 123123\r\n" | ||
| "3f\n" | ||
| "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n" | ||
|
|
@@ -2414,7 +2414,7 @@ TEST(HTTPBalsaFrame, | |
| "trAnsfer-eNcoding: chunked\r\n" | ||
| "\r\n"; | ||
| std::string message_body = | ||
| "A chunkjed extension \r\n" | ||
| "A chunked extension \r\n" | ||
| "01234567890 more crud including numbers 123123\r\n" | ||
| "3f\n" | ||
| "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n" | ||
|
|
@@ -2510,7 +2510,7 @@ TEST( | |
| "trAnsfer-eNcoding: chunked\r\n" | ||
| "\r\n"; | ||
| std::string message_body = | ||
| "A chunkjed extension \r\n" | ||
| "A chunked extension \r\n" | ||
| "01234567890 more crud including numbers 123123\r\n" | ||
| "3f\n" | ||
| "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\n" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -196,7 +196,7 @@ void BalsaHeaders::ParseTokenList(absl::string_view header_value, | |
| // found. marked. | ||
| const char* nws = start; | ||
|
|
||
| // search for next whitspace or separator char. | ||
| // search for next whitespace or separator char. | ||
| while (*start != ',' && static_cast<unsigned char>(*start) > ' ') { | ||
| ++start; | ||
| if (start == end) { | ||
|
|
@@ -625,7 +625,7 @@ void BalsaHeaders::RemoveAllOfHeaderInList(const HeaderTokenList& keys) { | |
| // This extra copy sacrifices some performance to prevent the possible | ||
| // mistakes that the caller does not lower case the headers in keys. | ||
| // Better performance can be achieved by asking caller to lower case | ||
| // the keys and RemoveAllOfheaderInlist just does lookup. | ||
| // the keys and RemoveAllOfheaderInList just does lookup. | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are quite a few cases where comments try to mention function names and don't get them right, you can see based on the context that this was one of them. |
||
| absl::flat_hash_set<std::string> lowercase_keys; | ||
| for (const auto& key : keys) { | ||
| MaybeClearSpecialHeaderValues(key); | ||
|
|
@@ -1102,7 +1102,7 @@ void BalsaHeaders::RemoveLastTokenFromHeaderValue(absl::string_view key) { | |
| GetHeaderLinesIterator(key, header_lines_.begin()); | ||
| if (it == header_lines_.end()) { | ||
| QUICHE_DLOG(WARNING) | ||
| << "Attempting to remove last token from a non-existent " | ||
| << "Attempting to remove last token from a nonexistent " | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Happy to drop this or anything else -- in general, I group changes by the resulting spelling so if you don't like a correction, you can flag it once and I'll drop the commit. |
||
| << "header \"" << key << "\""; | ||
| return; | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,7 @@ TEST(HeaderValidatorTest, ExceedsMaxSize) { | |
| EXPECT_EQ(HeaderValidator::HEADER_OK, status); | ||
| status = v.ValidateSingleHeader( | ||
| "name2", | ||
| "Antidisestablishmentariansism is supercalifragilisticexpialodocious."); | ||
| "Antidisestablishmentariansism is supercalifragilisticexpealidocious."); | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. both tokens were present in this repository. There was no obvious explanation for why this incorrect spelling was present. |
||
| EXPECT_EQ(HeaderValidator::HEADER_FIELD_TOO_LONG, status); | ||
| } | ||
|
|
||
|
|
@@ -432,7 +432,7 @@ TEST(HeaderValidatorTest, WebsocketPseudoHeaders) { | |
| } | ||
| EXPECT_EQ(HeaderValidator::HEADER_OK, | ||
| v.ValidateSingleHeader(":protocol", "websocket")); | ||
| // After allowing the method, `:protocol` is acepted for CONNECT requests. | ||
| // After allowing the method, `:protocol` is accepted for CONNECT requests. | ||
| EXPECT_TRUE(v.FinishHeaderBlock(HeaderType::REQUEST)); | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ const int kSendError = -902; | |
|
|
||
| constexpr absl::string_view kHeadValue = "HEAD"; | ||
|
|
||
| // TODO(birenroy): Consider incorporating spdy::FlagsSerializionVisitor here. | ||
| // TODO(birenroy): Consider incorporating spdy::FlagsSerializationVisitor here. | ||
| class FrameAttributeCollector : public spdy::SpdyFrameVisitor { | ||
| public: | ||
| FrameAttributeCollector() = default; | ||
|
|
@@ -1158,7 +1158,7 @@ void OgHttp2Session::OnStreamPadLength(spdy::SpdyStreamId stream_id, | |
| void OgHttp2Session::OnStreamPadding(spdy::SpdyStreamId /*stream_id*/, size_t | ||
| /*len*/) { | ||
| // Flow control was accounted for in OnStreamPadLength(). | ||
| // TODO(181586191): Pass padding to the visitor? | ||
| // TODO(b/181586191): Pass padding to the visitor? | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This matches the other instances for this TODO... |
||
| } | ||
|
|
||
| spdy::SpdyHeadersHandlerInterface* OgHttp2Session::OnHeaderFrameStart( | ||
|
|
@@ -1473,7 +1473,7 @@ void OgHttp2Session::OnWindowUpdate(spdy::SpdyStreamId stream_id, | |
| LatchErrorAndNotify(Http2ErrorCode::PROTOCOL_ERROR, | ||
| ConnectionError::kWrongFrameSequence); | ||
| } | ||
| // Do not inform the visitor of a WINDOW_UPDATE for a non-existent stream. | ||
| // Do not inform the visitor of a WINDOW_UPDATE for a nonexistent stream. | ||
| return; | ||
| } else { | ||
| if (streams_reset_.contains(stream_id)) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes
that thatis meaningful. In this casethat portionshould work just as well asthat that portioneven though there's technically a change in the parsing.