Add BackyardGarden flow (Don't accept this yet)

[Eobam]

This is the basic email flow for a new Slack onboarding thing, which is backyard-garden. I'm just making the PR because I don't want to keep syncing my fork, and I don't want to forget. I'll send a message somewhere when I need it approved/reviewed.

[sentry]

Bug: Class name mismatch: Slack::BackyardgardenFlow is called, but Slack::BackyardgardenJoinFlow is defined, causing a NameError.
_{Severity: CRITICAL | Confidence: High}

🔍 Detailed Analysis

The Slack::BackyardgardenFlow class is called in logins_controller.rb at line 294, but the actual job class is defined as Slack::BackyardgardenJoinFlow. This name mismatch will cause a NameError: uninitialized constant Slack::BackyardgardenFlow when the system attempts to enqueue the job during user login and onboarding, leading to a critical failure in the user provisioning process.

💡 Suggested Fix

Rename the called class in logins_controller.rb to Slack::BackyardgardenJoinFlow to match the defined job class, or rename the job class to Slack::BackyardgardenFlow.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: app/controllers/logins_controller.rb#L294

Potential issue: The `Slack::BackyardgardenFlow` class is called in
`logins_controller.rb` at line 294, but the actual job class is defined as
`Slack::BackyardgardenJoinFlow`. This name mismatch will cause a `NameError:
uninitialized constant Slack::BackyardgardenFlow` when the system attempts to enqueue
the job during user login and onboarding, leading to a critical failure in the user
provisioning process.

_{Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6671192}

[sentry]

Bug: The Slack::BackyardgardenJoinFlow job is missing the required perform method, causing NoMethodError during execution.
_{Severity: CRITICAL | Confidence: High}

🔍 Detailed Analysis

The Slack::BackyardgardenJoinFlow job defines a first_email_send method but lacks the required perform method. ActiveJob expects a perform method to execute the job's logic. When a background worker attempts to process this job, it will raise a NoMethodError: undefined method 'perform' for the job instance, preventing the intended email from being sent and causing the job to fail.

💡 Suggested Fix

Rename the first_email_send method to perform within the Slack::BackyardgardenJoinFlow class to align with ActiveJob's execution expectations.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: app/jobs/slack/backyard_garden.rb#L1-L7

Potential issue: The `Slack::BackyardgardenJoinFlow` job defines a `first_email_send`
method but lacks the required `perform` method. ActiveJob expects a `perform` method to
execute the job's logic. When a background worker attempts to process this job, it will
raise a `NoMethodError: undefined method 'perform'` for the job instance, preventing the
intended email from being sent and causing the job to fail.

_{Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6671192}

[sentry]

Bug: Mailer methods in BackyardgardenMailer lack corresponding view templates, causing ActionView::MissingTemplate when sending emails.
_{Severity: CRITICAL | Confidence: High}

🔍 Detailed Analysis

The BackyardgardenMailer defines methods like first_email, ysws_email, community_events, and clubs_email but lacks corresponding view templates (e.g., app/views/backyardgarden_mailer/first_email.html.erb). When BackyardGarden_Mailer.first_email(identity).deliver_now is called, Rails ActionMailer will raise an ActionView::MissingTemplate error because the required template files are absent, leading to a server crash during email delivery.

💡 Suggested Fix

Create the necessary html.erb and text.erb template files for each mailer method (e.g., first_email, ysws_email, community_events, clubs_email) in the app/views/backyardgarden_mailer/ directory.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: app/mailers/backyardgarden_mailer.rb#L1-L42

Potential issue: The `BackyardgardenMailer` defines methods like `first_email`,
`ysws_email`, `community_events`, and `clubs_email` but lacks corresponding view
templates (e.g., `app/views/backyardgarden_mailer/first_email.html.erb`). When
`BackyardGarden_Mailer.first_email(identity).deliver_now` is called, Rails ActionMailer
will raise an `ActionView::MissingTemplate` error because the required template files
are absent, leading to a server crash during email delivery.

_{Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6671192}