Skip to content

Add BackyardGarden flow (Don't accept this yet) #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eobam wants to merge 4 commits into
base: main
Choose a base branch
from
+52 −0
Open

Add BackyardGarden flow (Don't accept this yet) #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
48472fb
stuff
Eobam Dec 10, 2025
67cc2c5
Merge branch 'hackclub:main' into main
Eobam Dec 10, 2025
4f2e0c9
Add BackyardGarden flow
Eobam Dec 10, 2025
9a87d10
Merge branch 'hackclub:main' into main
Eobam Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/controllers/logins_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,8 @@
if Flipper.enabled?(:are_we_enterprise_yet, current_identity) && scenario.slack_onboarding_flow == :internal_tutorial
Tutorial::BeginJob.perform_later(@identity)
end

Check failure on line 293 in app/controllers/logins_controller.rb

View workflow job for this annotation

GitHub Actions / lint 

Layout/TrailingWhitespace: Trailing whitespace detected.
Slack::BackyardgardenFlow.perform_later(@identity)
Copy link

@sentry sentry bot Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Class name mismatch: Slack::BackyardgardenFlow is called, but Slack::BackyardgardenJoinFlow is defined, causing a NameError.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The Slack::BackyardgardenFlow class is called in logins_controller.rb at line 294, but the actual job class is defined as Slack::BackyardgardenJoinFlow. This name mismatch will cause a NameError: uninitialized constant Slack::BackyardgardenFlow when the system attempts to enqueue the job during user login and onboarding, leading to a critical failure in the user provisioning process.

💡 Suggested Fix

Rename the called class in logins_controller.rb to Slack::BackyardgardenJoinFlow to match the defined job class, or rename the job class to Slack::BackyardgardenFlow.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: app/controllers/logins_controller.rb#L294

Potential issue: The `Slack::BackyardgardenFlow` class is called in
`logins_controller.rb` at line 294, but the actual job class is defined as
`Slack::BackyardgardenJoinFlow`. This name mismatch will cause a `NameError:
uninitialized constant Slack::BackyardgardenFlow` when the system attempts to enqueue
the job during user login and onboarding, leading to a critical failure in the user
provisioning process.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6671192


slack_result
else
Expand Down
1 change: 1 addition & 0 deletions app/controllers/slack/interactivity_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@

head :ok
end

Check failure on line 37 in app/controllers/slack/interactivity_controller.rb

View workflow job for this annotation

GitHub Actions / lint 

Layout/TrailingWhitespace: Trailing whitespace detected.

def set_current_identity
payload = JSON.parse(params[:payload])
Expand Down
7 changes: 7 additions & 0 deletions app/jobs/slack/backyard_garden.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class Slack::BackyardgardenJoinFlow < ApplicationJob
queue_as :default

def first_email_send(identity)
BackyardGarden_Mailer.first_email(identity).deliver_now
end
end

Check failure on line 7 in app/jobs/slack/backyard_garden.rb

View workflow job for this annotation

GitHub Actions / lint 

Layout/TrailingEmptyLines: Final newline missing.
Comment on lines +1 to +7
Copy link

@sentry sentry bot Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The Slack::BackyardgardenJoinFlow job is missing the required perform method, causing NoMethodError during execution.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The Slack::BackyardgardenJoinFlow job defines a first_email_send method but lacks the required perform method. ActiveJob expects a perform method to execute the job's logic. When a background worker attempts to process this job, it will raise a NoMethodError: undefined method 'perform' for the job instance, preventing the intended email from being sent and causing the job to fail.

💡 Suggested Fix

Rename the first_email_send method to perform within the Slack::BackyardgardenJoinFlow class to align with ActiveJob's execution expectations.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: app/jobs/slack/backyard_garden.rb#L1-L7

Potential issue: The `Slack::BackyardgardenJoinFlow` job defines a `first_email_send`
method but lacks the required `perform` method. ActiveJob expects a `perform` method to
execute the job's logic. When a background worker attempts to process this job, it will
raise a `NoMethodError: undefined method 'perform'` for the job instance, preventing the
intended email from being sent and causing the job to fail.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6671192

42 changes: 42 additions & 0 deletions app/mailers/backyardgarden_mailer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
class BackyardGarden_Mailer < ApplicationMailer
def first_email(identity)
@identity = identity
@first_name = @identity.first_name

Check failure on line 5 in app/mailers/backyardgarden_mailer.rb

View workflow job for this annotation

GitHub Actions / lint 

Layout/TrailingWhitespace: Trailing whitespace detected.
mail(
to: @identity.primary_email,
subject: "Hack Club Onboarding"
)
end

def ysws_email(identity)
@identity = identity
@first_name = @identity.first_name

Check failure on line 15 in app/mailers/backyardgarden_mailer.rb

View workflow job for this annotation

GitHub Actions / lint 

Layout/TrailingWhitespace: Trailing whitespace detected.
mail(
to: @identity.primary_email,
subject: "YSWS Onboarding"
)
end

def community_events(identity)
@identity = identity
@first_name = @identity.first_name

Check failure on line 25 in app/mailers/backyardgarden_mailer.rb

View workflow job for this annotation

GitHub Actions / lint 

Layout/TrailingWhitespace: Trailing whitespace detected.
mail(
to: @identity.primary_email,
subject: "Community Events Onboarding"
)
end

def clubs_email(identity)
@identity = identity
@first_name = @identity.first_name

Check failure on line 35 in app/mailers/backyardgarden_mailer.rb

View workflow job for this annotation

GitHub Actions / lint 

Layout/TrailingWhitespace: Trailing whitespace detected.
mail(
to: @identity.primary_email,
subject: "Putting the Club in Hack Club"
)
end

Check failure on line 41 in app/mailers/backyardgarden_mailer.rb

View workflow job for this annotation

GitHub Actions / lint 

Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.
end

Check failure on line 42 in app/mailers/backyardgarden_mailer.rb

View workflow job for this annotation

GitHub Actions / lint 

Layout/TrailingEmptyLines: Final newline missing.
Comment on lines +32 to +42
Copy link

@sentry sentry bot Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Mailer methods in BackyardgardenMailer lack corresponding view templates, causing ActionView::MissingTemplate when sending emails.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The BackyardgardenMailer defines methods like first_email, ysws_email, community_events, and clubs_email but lacks corresponding view templates (e.g., app/views/backyardgarden_mailer/first_email.html.erb). When BackyardGarden_Mailer.first_email(identity).deliver_now is called, Rails ActionMailer will raise an ActionView::MissingTemplate error because the required template files are absent, leading to a server crash during email delivery.

💡 Suggested Fix

Create the necessary html.erb and text.erb template files for each mailer method (e.g., first_email, ysws_email, community_events, clubs_email) in the app/views/backyardgarden_mailer/ directory.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: app/mailers/backyardgarden_mailer.rb#L1-L42

Potential issue: The `BackyardgardenMailer` defines methods like `first_email`,
`ysws_email`, `community_events`, and `clubs_email` but lacks corresponding view
templates (e.g., `app/views/backyardgarden_mailer/first_email.html.erb`). When
`BackyardGarden_Mailer.first_email(identity).deliver_now` is called, Rails ActionMailer
will raise an `ActionView::MissingTemplate` error because the required template files
are absent, leading to a server crash during email delivery.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6671192

Loading