[Test] Bump pipeline to node version 20 #953
Conversation
Bumping pipeline to node version 20 in preparation for Docosaurus migration to 3.9 which requires it Signed-off-by: Martin Dekov <martin.dekov@suse.com>
Signed-off-by: Martin Dekov <martin.dekov@suse.com>
github-actions
bot
requested review from
akashraj4261,
dariavladykina and
jillian-maroket
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the Node.js version from 18 to 20 across GitHub Actions workflows to test compatibility with Docusaurus 2.4 before a planned migration to Docusaurus 3.9.
Changes:
- Node.js version upgraded from 18 to 20 in CI/CD pipelines
- GitHub Actions setup-node action upgraded from v4 to v6
- Pull request trigger changed from pull_request_target to pull_request (unrelated to Node upgrade)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release.yml | Updates Node.js version to 20 and setup-node action to v6 for release builds |
| .github/workflows/pull-request.yml | Updates Node.js version to 20, setup-node action to v6, and changes workflow trigger from pull_request_target to pull_request |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| on: | ||
| pull_request_target: | ||
| pull_request: |
There was a problem hiding this comment.
Changing from 'pull_request_target' to 'pull_request' is a significant security change. The 'pull_request_target' trigger runs in the context of the base repository and has access to secrets, which is necessary for deploying to Netlify. The 'pull_request' trigger runs in the context of the fork and doesn't have access to repository secrets by default. This change will likely cause the deployment to fail when trying to access NETLIFY_SITE_ID and NETLIFY_AUTH_TOKEN secrets. Unless there's a specific reason for this change, consider reverting to 'pull_request_target' or ensuring the workflow doesn't require secrets.
| pull_request: | |
| pull_request_target: |
|
Testing whether docosaurus 2.4 can be built by node version 20 so Docosaurus 3.9 build can be merged in 2 stages - pipeline and then core migration itself as opposed to doing the whole thing at once
Problem:
Solution:
Related Issue(s):
Test plan:
Additional documentation or context