Skip to content

[Test] Bump pipeline to node version 20 #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martindekov wants to merge 2 commits into from
Closed

[Test] Bump pipeline to node version 20 #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8b33ff
Bump pipeline to node version 20
martindekov Jan 14, 2026
4c11e6d
Temporary use pipeline config
martindekov Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Pull Request Preview

on:
pull_request_target:
pull_request:
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from 'pull_request_target' to 'pull_request' is a significant security change. The 'pull_request_target' trigger runs in the context of the base repository and has access to secrets, which is necessary for deploying to Netlify. The 'pull_request' trigger runs in the context of the fork and doesn't have access to repository secrets by default. This change will likely cause the deployment to fail when trying to access NETLIFY_SITE_ID and NETLIFY_AUTH_TOKEN secrets. Unless there's a specific reason for this change, consider reverting to 'pull_request_target' or ensuring the workflow doesn't require secrets.

Suggested change
pull_request:
pull_request_target:

Copilot uses AI. Check for mistakes.

concurrency:
group: ${{ github.workflow }}-${{ github.event.number }}
Expand All @@ -17,10 +17,10 @@ jobs:
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Set up Node.js 18
uses: actions/setup-node@v4
- name: Set up Node.js 20
uses: actions/setup-node@v6
with:
node-version: 18
node-version: 20

- name: Install dependencies
run: |
Expand All @@ -43,10 +43,10 @@ jobs:
pull-requests: write
needs: prepare
steps:
- name: Set up Node.js 18
uses: actions/setup-node@v4
- name: Set up Node.js 20
uses: actions/setup-node@v6
with:
node-version: 18
node-version: 20

- name: Install dependencies
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up Node.js 18
uses: actions/setup-node@v4
- name: Set up Node.js 20
uses: actions/setup-node@v6
with:
node-version: 18
node-version: 20

- name: Install dependencies
run: |
Expand Down
Loading