Conversation
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
590783e to
928d59c
Compare
|
@ipa-hsd Would you like to review, and if approved, merge this here, or should I open a new PR to https://github.com/ros2/ros1_bridge |
|
@v-lopez I am currently reviewing it. |
|
Thanks, I just pushed some changes that might have fixed the compilation in foxy. I was building on rolling and the action client API had changed. |
|
makes sense why I was having build issues and was not generating the interfaces anymore. When I made the PR it was successfully generating the interfaces and the bridge worked well. Thanks for the effort. |
|
No problem. There's still one more issue there, I just started a foxy docker and will try to fix it. Apologies for the confusion. |
Signed-off-by: Victor Lopez <victor.lopez@pal-robotics.com>
4cf1491 to
6b945fb
Compare
|
Should be ready now, let me know if you have any issues, I was able to build on foxy and rolling. |
|
did you build the bridge against |
|
rolling are debians made from most recent changes, maybe master from a few days/weeks ago. Did you have any issues? |
|
silly of me. I was just trying to avoid building ROS2 from source and still get the latest version. Will try the master. |
|
I finally had to build it against lastSuccessfulBuild since the master branches have compile errors. Your version of
Which action interface did you test it for? |
|
I tried with the tf msgs and control_msgs. Which ones are missing? |
|
alright I installed |
No description provided.