Feat: adding self.training argument to implement KV cache during validation and inference#94
Open
adityavipradas wants to merge 3 commits intohuggingface:mainfrom
Open
Conversation
added self.training argument to build KV cache only during inference and evaluation
replaced self.training with torch.is_grad_enabled()
Collaborator
|
If |
Author
|
model.eval() is right where it needs to be. What we need is:
If building KV cache during validation is fine, we can use self.training or torch.is_grad_enabled(). Please let me know and I will make the modifications accordingly. Thank you. |
both torch.is_grad_enabled() and self.training lead to the same KV cache building outcome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving issue #92
Added self.training argument in language_model.py to populate KV cache during inference, validation and set it to [None] during training.