Open
Conversation
Add null termination checking for str's FromBytesWithInputBorrowed implementation. The check also ensures there's no interior null bytes in the string. While here change to use more safe pattern for indexing the underlying slice. With this change it's now possible to implement String's FromBytesWithInput by reading str first and then making it owned reducing code duplication.
…entation And then use &[u8] FromBytesWithInputBorrowed in str's FromBytesWithInputBorrowed.
Owner
|
@oherrala I believe this is addressing the problem of the null terminator being included in the String, is that correct? If so, I believe this does not qualify as a bug fix and needs to target v0.8.0 unfortunately. It's not causing an error or failures and I don't want to break anyone who may have already worked around this unfortunate bug in the code. |
Owner
Contributor
Author
|
@jbaublitz Sure, go ahead! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanups to basic types implementing
FromBytes,FromBytesWithInput,FromBytesWithInputBorrowed.&strimplementation ofFromBytesWithInputBorrowedto handle string as null terminated. This might have been a bug? Now it also validates proper null termination without interior null bytes.&strreader to use&[u8]'sFromBytesWithInputBorrowedto access bufferStringreader to use&str'sFromBytesWithInputBorrowedVec<T>'s reader for consistent styleinputparameter to consistently beSelf::Inputsince some wereusize