fix: add search infrastructure readiness gate for CI stability#105
Merged
fix: add search infrastructure readiness gate for CI stability#105
Conversation
Publish workflow failed on macOS because tests ran before VSCode's search infrastructure was ready, causing ripgrep to return 0 results. Adds a polling loop in verifyWorkspace() that confirms findFiles works before tests begin, increases macOS CI timeout multiplier to 2x, and sets fail-fast: false for better cross-platform diagnostics.
Contributor
|
✅ Tests passed on ubuntu-latest |
Contributor
|
✅ Tests passed on macos-latest |
Contributor
|
✅ Tests passed on windows-latest |
2 tasks
Contributor
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyWorkspace()that pollsvscode.workspace.findFiles()up to 5 times before tests begin, ensuring the search infrastructure is operationalfail-fast: falsein the test matrix so all platform results are collected even when one failsContext
The Publish workflow failed on macOS with 12/139 tests failing — all due to ripgrep returning 0 results. The same commit passed in the standalone Tests workflow. Root cause: tests started before VSCode's search infrastructure finished indexing the fixture workspace.
Test plan