Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

Comments

Fixed jspm/npm#101: mathcing more dependency formats for npm#109

Closed
vadimpopa wants to merge 2 commits intojspm:masterfrom
vadimpopa:jspm/npm#101
Closed

Fixed jspm/npm#101: mathcing more dependency formats for npm#109
vadimpopa wants to merge 2 commits intojspm:masterfrom
vadimpopa:jspm/npm#101

Conversation

@vadimpopa
Copy link

Fixed #101: mathcing more dependency formats for pm.
Regex unit tests here: https://regex101.com/r/dS1fJ6/3

@vadimpopa
Copy link
Author

Just noticed #96, so consider to close it because of this and because some formats will pass the reg-ex here, but will still fail in processPackageConfig - which probably is fixed in #96.

@guybedford
Copy link
Member

Yes this is resolved properly in #96 with https://github.com/jspm/npm/pull/96/files#diff-59adaa9915a15ff8ed1f21fd655d5378R374 and https://github.com/jspm/npm/pull/96/files#diff-59adaa9915a15ff8ed1f21fd655d5378L256, but if you are interested in backporting to this release I'd consider including it.

@guybedford guybedford closed this Jun 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants