Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

Fixed jspm/npm#101: mathcing more dependency formats for npm #109

Closed
vadimpopa wants to merge 2 commits into from
Closed

Fixed jspm/npm#101: mathcing more dependency formats for npm #109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4a7422
Fixed jspm/npm#101: mathcing more dependency formats for npm
vadimpopa Dec 7, 2015
59047bc
Fixed jspm/npm#101: remove optional check
vadimpopa Dec 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/npm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ NPMLocation.prototype = {

// warn if using jspm-style dependencies at this point
for (var d in pjson.dependencies)
if (!pjson.dependencies[d].match(/^(https?|git)[:+]/) && pjson.dependencies[d].indexOf(':') > 0)
if (!pjson.dependencies[d].match(/^(https?|git)[:+]|(.)[:\/]/))
throw 'Package.json dependency %' + d + '% set to `' + pjson.dependencies[d] + '`, which is not a valid dependency format for npm.'
+ '\nIt\'s advisable to publish jspm-style packages to GitHub or another `registry` so conventions are clear.';
+ '\nTo skip npm compatibility install with %jspm install ' + packageName + '-o "{jspmNodeConversion: false}"%.'
Expand Down