-
-
Notifications
You must be signed in to change notification settings - Fork 133
feat(web): implement SearchCluster splitting 🚂 #15031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jahorton
wants to merge
2
commits into
change/web/prepare-for-divergent-splits
Choose a base branch
from
feat/web/cluster-splitting-and-merging
base: change/web/prepare-for-divergent-splits
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(web): implement SearchCluster splitting 🚂 #15031
jahorton
wants to merge
2
commits into
change/web/prepare-for-divergent-splits
from
feat/web/cluster-splitting-and-merging
+568
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
72798ba to
e5083de
Compare
8adec0a to
fe15157
Compare
4e17f64 to
8df54e8
Compare
e65ad7c to
5f1ce79
Compare
2989607 to
7e82b72
Compare
ef700d0 to
567ba68
Compare
7e82b72 to
6bbdb8d
Compare
567ba68 to
0286e3c
Compare
6bbdb8d to
39ac356
Compare
18c246a to
d98603f
Compare
0eddcf8 to
dadefba
Compare
eaac92f to
403721b
Compare
dadefba to
ec12918
Compare
bb2c119 to
e69bb62
Compare
ec12918 to
345c949
Compare
e69bb62 to
71df397
Compare
345c949 to
e3ce01f
Compare
71df397 to
1f4897f
Compare
e3ce01f to
d097728
Compare
1f4897f to
56d7a8f
Compare
d097728 to
c31523a
Compare
c31523a to
8f7363d
Compare
Build-bot: skip build:web Test-bot: skip
fccd35e to
4f1435c
Compare
8f7363d to
98d2043
Compare
ermshiperete
approved these changes
Feb 11, 2026
| // in its history, but it reconverges before the end. | ||
| assert.isTrue(cleanSplit[1] instanceof SearchQuotientSpur); | ||
| // Note that the path structures themselves, however, will be rebuilt - | ||
| // and with new spaceIDs.ß |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| // and with new spaceIDs.ß | |
| // and with new spaceIDs. |
| const cleanTail = seq.slice(splitIndex+1); | ||
|
|
||
| const splitSegment = seq[splitIndex]; | ||
| const segmentSplitIndex = splitSegment.codepointLength - splitLocation; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? search-quotient-spur.ts uses
const internalSplitIndex = charIndex - (this.codepointLength - this.insertLength);
so I'm wondering if this should be ?
Suggested change
| const segmentSplitIndex = splitSegment.codepointLength - splitLocation; | |
| const segmentSplitIndex = splitLocation - (splitSegment.codepointLength - splitSegment.insertLength); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves to implement
SearchQuotientCluster.split()in full, meeting the following criteria:- This requires (live) use of the
.isSameNode()method from feat(web): add isSameNode for duplicate quotient-node detection 🚂 #15478, which is designed to identify such cases. It thus is no longer unit-test only.- We must not group left-hand side paths (or right-hand side paths) that represent different subsets of the user's original keystrokes.
SearchQuotientClustertype should be leveraged for results where applicable - where two or more paths converge to the same total subset of keystroke input + codepoint length.Build-bot: skip build:web
Test-bot: skip