-
-
Notifications
You must be signed in to change notification settings - Fork 133
chore(core): Remove km_core_keyboard_attrs.folder_path 🎼
#15471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: epic/web-core
Are you sure you want to change the base?
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
km_core_keyboard_attrs.folder_pathkm_core_keyboard_attrs.folder_path 🎼
20cd352 to
812b93e
Compare
812b93e to
0422b3f
Compare
mcdurdin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this change. We have not published an API stability policy but perhaps we need to. For example GNOME's policy.
Removal of fields is not backwardly compatible; the question in my mind is if we need to maintain backward compatibility for Core because it is normally tightly linked to a release. (If we have other consumers of the Keyman Core API, then this will become a more serious question.)
If we do publish this, it is a Keyman Core API change that needs to be listed in our 19.0 changes wiki
PR #12769 removed
km_core_keyboard_loadthat allowed loading a keyboard from a path. Instead we now pass a BLOB to core to load a keyboard. With the function gone there is no longer a need to have a field with the path.Follow-up-of: #12497
Related-to: #12769
Test-bot: skip