Skip to content

chore(core): Remove km_core_keyboard_attrs.folder_path 🎼 #15471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ermshiperete wants to merge 2 commits into
base: epic/web-core
Choose a base branch
from
+2 −19
Open

chore(core): Remove km_core_keyboard_attrs.folder_path 🎼 #15471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0422b3f
chore(core): Remove `km_core_keyboard_attrs.folder_path`
ermshiperete Jan 19, 2026
de49944
chore(web): remove `keyboard_attributes._folder_path`
ermshiperete Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions core/docs/api/keyboards.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ Provides read-only information about a keyboard.
typedef struct {
km_core_cp const * version_string;
km_core_cp const * id;
km_core_path_name folder_path;
km_core_option_item const * default_options;
} km_core_keyboard_attrs;

Expand All @@ -33,9 +32,6 @@ typedef struct {
`id`
: Keyman keyboard ID string.

`folder_path`
: Path to the unpacked folder containing the keyboard and associated resources.

`default_options`
: Set of default values for any options included in the keyboard.

Expand Down Expand Up @@ -662,4 +658,4 @@ km_core_state_to_json(km_core_state const *state,
[km_core_event_flags]: processor#km_core_event_flags "km_core_event_flags enum"
[km_core_process_event]: processor#km_core_process_event "km_core_process_event function"
[km_core_event]: processor#km_core_event "km_core_event function"
[km_core_event_code]: processor#km_core_event_code "km_core_event_code enum"
[km_core_event_code]: processor#km_core_event_code "km_core_event_code enum"
8 changes: 0 additions & 8 deletions core/include/keyman/keyman_core_api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,11 +1011,6 @@ Provides read-only information about a keyboard.
typedef struct {
km_core_cu const * version_string;
km_core_cu const * id;

// TODO-web-core: Deprecate this field (#12497)
// KMN_DEPRECATED
km_core_path_name folder_path;

km_core_option_item const * default_options;
} km_core_keyboard_attrs;

Expand All @@ -1029,9 +1024,6 @@ typedef struct {
`id`
: Keyman keyboard ID string.

`folder_path`
: Path to the unpacked folder containing the keyboard and associated resources (deprecated).

`default_options`
: Set of default values for any options included in the keyboard.

Expand Down
2 changes: 0 additions & 2 deletions core/src/keyboard.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ keyboard_attributes::keyboard_attributes(std::u16string const & kbid,
options_store const &opts)
: _keyboard_id(kbid),
_version_string(version),
_folder_path(""),
_default_opts(opts)
{
// Ensure that the default_options array will be properly terminated.
Expand All @@ -38,7 +37,6 @@ keyboard_attributes::keyboard_attributes(std::u16string const & kbid,
keyboard_attributes::keyboard_attributes(keyboard_attributes &&rhs)
: _keyboard_id(std::move(rhs._keyboard_id)),
_version_string(std::move(rhs._version_string)),
_folder_path(""),
_default_opts(std::move(rhs._default_opts))
{
rhs.id = rhs.version_string = nullptr;
Expand Down
4 changes: 1 addition & 3 deletions core/src/keyboard.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ namespace core
{
std::u16string _keyboard_id;
std::u16string _version_string;
// unused and deprecated
core::path _folder_path;
std::vector<option> _default_opts;

void render();
Expand All @@ -36,7 +34,7 @@ namespace core
using options_store = decltype(_default_opts);

keyboard_attributes()
: km_core_keyboard_attrs {nullptr, nullptr, nullptr, nullptr} {}
: km_core_keyboard_attrs {nullptr, nullptr, nullptr} {}
keyboard_attributes(keyboard_attributes const &) = delete;
keyboard_attributes(keyboard_attributes &&);

Expand Down
1 change: 0 additions & 1 deletion developer/src/tike/main/Keyman.System.KeymanCore.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ function km_core_state_options_to_json(
km_core_keyboard_attrs = record
version_string: pkm_core_cu;
id: pkm_core_cu;
folder_path: km_core_path_name;
default_optons: pkm_core_option_item
end;

Expand Down