-
-
Notifications
You must be signed in to change notification settings - Fork 42
maint: add TC build scripts for models 🪶 #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5fb9291
maint: add TC build scripts for models
ermshiperete e99d624
maint: address code review comments
ermshiperete a9804a4
Apply suggestions from code review
mcdurdin 827c814
maint: remove now-unused servervars.sh references
mcdurdin 39a04ac
Merge branch 'master' into maint/14192_tconfig
mcdurdin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,59 @@ | ||||||||||||||||||||||||
| #!/usr/bin/env bash | ||||||||||||||||||||||||
| # Keyman is copyright (C) SIL Global. MIT License. | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| # shellcheck disable=SC2164 | ||||||||||||||||||||||||
| # shellcheck disable=SC1091 | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| ## START STANDARD BUILD SCRIPT INCLUDE | ||||||||||||||||||||||||
| # adjust relative paths as necessary | ||||||||||||||||||||||||
| THIS_SCRIPT="$(readlink -f "${BASH_SOURCE[0]}")" | ||||||||||||||||||||||||
| . "${THIS_SCRIPT%/*}/../../../resources/builder.inc.sh" | ||||||||||||||||||||||||
| ## END STANDARD BUILD SCRIPT INCLUDE | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| ################################ Main script ################################ | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| builder_describe \ | ||||||||||||||||||||||||
| "Build and deploy models" \ | ||||||||||||||||||||||||
| "all run all actions" \ | ||||||||||||||||||||||||
| "build build models" \ | ||||||||||||||||||||||||
| "publish deploy models" \ | ||||||||||||||||||||||||
| "--downloads-keyman-com=DOWNLOADS_KEYMAN_COM_URL URL of downloads server" \ | ||||||||||||||||||||||||
| "--rsync-path=REMOTE_RSYNC_PATH Path to rsync on remote server" \ | ||||||||||||||||||||||||
| "--rsync-dest=RSYNC_DEST Destination for rsync" | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| builder_parse "$@" | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| export DOWNLOADS_KEYMAN_COM_URL | ||||||||||||||||||||||||
| export REMOTE_RSYNC_PATH | ||||||||||||||||||||||||
| export RSYNC_DEST | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| function do_build() { | ||||||||||||||||||||||||
| builder_echo "Building all models" | ||||||||||||||||||||||||
| "${REPO_ROOT}/build.sh" configure build test | ||||||||||||||||||||||||
| builder_echo "Finished building all models" | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| function do_publish() { | ||||||||||||||||||||||||
| if [[ -z "${DOWNLOADS_KEYMAN_COM_URL+x}" ]]; then | ||||||||||||||||||||||||
| builder_die "Option --downloads-keyman-com must be specified for publish action" | ||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||
| if [[ -z "${REMOTE_RSYNC_PATH+x}" ]]; then | ||||||||||||||||||||||||
| builder_die "Option --rsync-path must be specified for publish action" | ||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||
| if [[ -z "${RSYNC_DEST+x}" ]]; then | ||||||||||||||||||||||||
| builder_die "Option --rsync-dest must be specified for publish action" | ||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||
| builder_echo "Uploading models to downloads.keyman.com" | ||||||||||||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||
| "${REPO_ROOT}/ci.sh" | ||||||||||||||||||||||||
| builder_echo "Finished uploading models to downloads.keyman.com" | ||||||||||||||||||||||||
| } | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| cd "${REPO_ROOT}" | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| if builder_has_action all; then | ||||||||||||||||||||||||
| do_build | ||||||||||||||||||||||||
| do_publish | ||||||||||||||||||||||||
| else | ||||||||||||||||||||||||
| builder_run_action build do_build | ||||||||||||||||||||||||
| builder_run_action publish do_publish | ||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| #!/usr/bin/env bash | ||
| # Keyman is copyright (C) SIL Global. MIT License. | ||
|
|
||
| # shellcheck disable=SC2164 | ||
| # shellcheck disable=SC1091 | ||
|
|
||
| ## START STANDARD BUILD SCRIPT INCLUDE | ||
| # adjust relative paths as necessary | ||
| THIS_SCRIPT="$(readlink -f "${BASH_SOURCE[0]}")" | ||
| . "${THIS_SCRIPT%/*}/../../../resources/builder.inc.sh" | ||
| ## END STANDARD BUILD SCRIPT INCLUDE | ||
|
|
||
| ################################ Main script ################################ | ||
|
|
||
| builder_describe \ | ||
| "Test build of pull request" \ | ||
| "all run all actions" | ||
|
|
||
| builder_parse "$@" | ||
|
|
||
| function do_build() { | ||
| builder_echo "Building all models" | ||
| "${REPO_ROOT}/build.sh" configure build test | ||
| builder_echo "Finished building all models" | ||
| } | ||
|
|
||
| cd "${REPO_ROOT}" | ||
|
|
||
| builder_run_action all do_build |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done