maint: add TC build scripts for models 🪶#319
Merged
Conversation
Fixes: #14192 Part-of: #13399 Test-bot: skip
ermshiperete
changed the title
mcdurdin
requested changes
Aug 28, 2025
Comment on lines
+20
to
+22
| "--downloads-keyman-com=DOWNLOADS_KEYMAN_COM_URL URL of downloads server" \ | ||
| "--rsync-path=REMOTE_RSYNC_PATH Path to rsync on remote server" \ | ||
| "--rsync-dest=RSYNC_DEST Destination for rsync" |
Member
There was a problem hiding this comment.
- Do these variables need to be exported in order for them to be available to ci.sh?
| } | ||
|
|
||
| function do_publish() { | ||
| builder_echo "Uploading models to downloads.keyman.com" |
Member
There was a problem hiding this comment.
Suggested change
| builder_echo "Uploading models to downloads.keyman.com" | |
| if [[ -z "${DOWNLOADS_KEYMAN_COM_URL+x}" ]]; then | |
| builder_die "Option --downloads-keyman-com must be specified for publish action" | |
| fi | |
| if [[ -z "${REMOTE_RSYNC_PATH+x}" ]]; then | |
| builder_die "Option --rsync-path must be specified for publish action" | |
| fi | |
| if [[ -z "${RSYNC_DEST+x}" ]]; then | |
| builder_die "Option --rsync-dest must be specified for publish action" | |
| fi | |
| builder_echo "Uploading models to downloads.keyman.com" |
|
|
||
| function do_build() { | ||
| builder_echo "Building all models" | ||
| "${REPO_ROOT}/build.sh" |
Member
There was a problem hiding this comment.
Suggested change
| "${REPO_ROOT}/build.sh" | |
| "${REPO_ROOT}/build.sh" configure build test |
If test is not being run, then it should be. It's still a no-op but at least the connections are in place!
Co-authored-by: Marc Durdin <marc@durdin.net>
mcdurdin
approved these changes
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: keymanapp/keyman#14192
Part-of: keymanapp/keyman#13399
Test-bot: skip