Skip to content

GFF Amharic Lexical Model v2.0#330

Merged
DavidLRowe merged 15 commits intokeymanapp:masterfrom
dyacob:gff.am.gff_amharic-v2.0
Oct 3, 2025
Merged

GFF Amharic Lexical Model v2.0#330
DavidLRowe merged 15 commits intokeymanapp:masterfrom
dyacob:gff.am.gff_amharic-v2.0

Conversation

@dyacob
Copy link
Contributor

@dyacob dyacob commented Oct 2, 2025

This revision of the GFF Amharic lexical model breaks away from the UniLex resource. The lexical model is now based on two corpus collections, one for newspapers and one for ebooks. See the README.md for a detailed description. Some rationale for making this shift:

  • UniLex sources are unknown and have unknown provenance.
  • UniLex is built from a large corpus of unknown quality and content.
  • UniLex content sometimes misidentifies the language.
  • The update addresses these problems; all content is now identifiable, traceable, and may be reviewed and revised if issues are found.

Question: In the README.md , does it make sense to have the "Supported Platforms" section? My understanding is that the dictionaries were device-independent. I would like to remove it if it is superfluous.

@keyman-server
Copy link

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@DavidLRowe
Copy link
Collaborator

I think you are correct that the platform information in the README.md is not needed and can be removed.

@dyacob
Copy link
Contributor Author

dyacob commented Oct 3, 2025

Thank you @DavidLRowe , I've just removed it and pushed in an update.

@DavidLRowe
Copy link
Collaborator

Are this ready for review?

@dyacob
Copy link
Contributor Author

dyacob commented Oct 3, 2025

Yes, it is a ready for review, thanks.

@DavidLRowe DavidLRowe merged commit a37bf3f into keymanapp:master Oct 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants