GFF Amharic Lexical Model v2.0#330
Merged
DavidLRowe merged 15 commits intokeymanapp:masterfrom Oct 3, 2025
Merged
Conversation
|
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
Collaborator
|
I think you are correct that the platform information in the README.md is not needed and can be removed. |
Contributor
Author
|
Thank you @DavidLRowe , I've just removed it and pushed in an update. |
Collaborator
|
Are this ready for review? |
Contributor
Author
|
Yes, it is a ready for review, thanks. |
DavidLRowe
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revision of the GFF Amharic lexical model breaks away from the UniLex resource. The lexical model is now based on two corpus collections, one for newspapers and one for ebooks. See the README.md for a detailed description. Some rationale for making this shift:
Question: In the README.md , does it make sense to have the "Supported Platforms" section? My understanding is that the dictionaries were device-independent. I would like to remove it if it is superfluous.