feat: add local docker training example#2869
feat: add local docker training example#2869briangallagher wants to merge 1 commit intokubeflow:masterfrom
Conversation
Signed-off-by: Brian Gallagher <briangal@gmail.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 18132078761Details
💛 - Coveralls |
astefanutti
left a comment
astefanutti
left a comment
There was a problem hiding this comment.
Just to be sure about the precedent / pattern that's going to be established with this, do we want the local run examples to live in the trainer (or other corresponding projects) or in the SDK itself?
| "name": "stdout", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "\u001B[33mDEPRECATION: git+https://github.com/briangallagher/sdk.git@docker-backend#egg=kubeflow[docker] contains an egg fragment with a non-PEP 508 name. pip 25.3 will enforce this behaviour change. A possible replacement is to use the req @ url syntax, and remove the egg fragment. Discussion can be found at https://github.com/pypa/pip/issues/13157\u001B[0m\u001B[33m\r\n", |
There was a problem hiding this comment.
Maybe let's hold this for kubeflow/sdk#111 to be merged so this can be updated.
|
@briangallagher Please can we initially add example on how to run LocalProcessBackend ? |
Since we use TrainerClient(), it might be easier to place examples in In the future, we can discuss what examples should live in the |
|
@kramaranya @briangallagher Are we targeting to finish this PR before v2.1 release ? |
|
@andreyvelich Fiona will take this over as part of her work on sdk/pull/119 |
|
This has been added in: #2907 |
|
@andreyvelich: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
What this PR does / why we need it:
An example notebook demonstrating the trainer running locally with docker.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #2868