Conversation
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR introduces a dedicated Helm test workflow to run Helm unit tests separately from code quality checks. It creates test-helm.yaml that executes make helm-unittest, which runs the helm-unittest plugin against test files in the charts directory. This follows the separation of concerns discussed in #3224, keeping test workflows focused and extensible.
Changes:
- Added
.github/workflows/test-helm.yamlto run Helm unit tests on pull requests and pushes
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
| contents: read | ||
|
|
||
| jobs: | ||
| helm-tests: |
There was a problem hiding this comment.
Let's keep it consistent with Go/Python
| helm-tests: | |
| test: |
| @@ -0,0 +1,26 @@ | |||
| name: Helm Tests | |||
There was a problem hiding this comment.
Can we name it as:
| name: Helm Tests | |
| name: Unit and Integration Test - Helm |
| - name: Run Helm Unit Tests | ||
| run: make helm-unittest |
There was a problem hiding this comment.
Please can you open an issue to add E2E tests with Helm to this workflow?
We can do that in the next PRs.
| - name: Setup Go | ||
| uses: actions/setup-go@v6 | ||
| with: | ||
| go-version-file: go.mod |
Following the recent review feedback, this PR moves Helm unit tests into a dedicated workflow (
test-helm.yaml).The goal is to keep the Code Quality workflow focused strictly on linting, while Helm-related tests run separately. This keeps responsibilities clear and makes it easier to extend Helm testing in the future (for example, adding Helm E2E tests).
This change follows the discussion in #3224
This PR supersedes #3166.