Skip to content

feat: Helm test workflow#3228

Open
Goku2099 wants to merge 7 commits intokubeflow:masterfrom
Goku2099:feat/add-helm-ci-checks
Open

feat: Helm test workflow#3228
Goku2099 wants to merge 7 commits intokubeflow:masterfrom
Goku2099:feat/add-helm-ci-checks

Conversation

@Goku2099
Copy link
Contributor

Following the recent review feedback, this PR moves Helm unit tests into a dedicated workflow (test-helm.yaml).

The goal is to keep the Code Quality workflow focused strictly on linting, while Helm-related tests run separately. This keeps responsibilities clear and makes it easier to extend Helm testing in the future (for example, adding Helm E2E tests).

This change follows the discussion in #3224

This PR supersedes #3166.

Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Signed-off-by: Sameer_yadav <159073326+Goku2099@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 19, 2026 20:05
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andreyvelich for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Goku2099 Goku2099 changed the title feat: ci(helm): Helm test workflow feat: Helm test workflow Feb 19, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a dedicated Helm test workflow to run Helm unit tests separately from code quality checks. It creates test-helm.yaml that executes make helm-unittest, which runs the helm-unittest plugin against test files in the charts directory. This follows the separation of concerns discussed in #3224, keeping test workflows focused and extensible.

Changes:

  • Added .github/workflows/test-helm.yaml to run Helm unit tests on pull requests and pushes

Goku2099 and others added 3 commits February 20, 2026 01:42
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sameer_Yadav <159073326+Goku2099@users.noreply.github.com>
contents: read

jobs:
helm-tests:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it consistent with Go/Python

Suggested change
helm-tests:
test:

@@ -0,0 +1,26 @@
name: Helm Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we name it as:

Suggested change
name: Helm Tests
name: Unit and Integration Test - Helm

Comment on lines +25 to +26
- name: Run Helm Unit Tests
run: make helm-unittest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you open an issue to add E2E tests with Helm to this workflow?

We can do that in the next PRs.

Comment on lines +20 to +23
- name: Setup Go
uses: actions/setup-go@v6
with:
go-version-file: go.mod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments