Skip to content

Comments

observer: remove TCP prober#8637

Merged
beautifulentropy merged 1 commit intomainfrom
no-tcp-prober
Feb 23, 2026
Merged

observer: remove TCP prober#8637
beautifulentropy merged 1 commit intomainfrom
no-tcp-prober

Conversation

@jsha
Copy link
Contributor

@jsha jsha commented Feb 20, 2026

It's unused per #8621.

@jsha jsha marked this pull request as ready for review February 23, 2026 18:02
@jsha jsha requested a review from a team as a code owner February 23, 2026 18:02
@jsha jsha requested a review from aarongable February 23, 2026 18:02
@github-actions
Copy link
Contributor

@jsha, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values.

Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the only use of obsclient.Dialer() outside of the TLS prober. I think we can simplify the obsclient package as part of this.

@jsha
Copy link
Contributor Author

jsha commented Feb 23, 2026

Good suggestion. Tried this, but noticed that obsclient.Client() also calls Dialer(). So if I moved the implementation of Dialer() into the probers/tls package, I'd also have to duplicate it internally to Client(). It's a trivial amount of code so the duplication is not bad from that perspective, but it's nice to unify the comment in a single place, so I'm inclined to keep obsclient.Dialer().

@beautifulentropy beautifulentropy self-requested a review February 23, 2026 21:20
Copy link
Member

@beautifulentropy beautifulentropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I expected there to be an entry in cmd/boulder-observer/README.md for this, but nope!

@beautifulentropy beautifulentropy merged commit edbb62c into main Feb 23, 2026
31 checks passed
@beautifulentropy beautifulentropy deleted the no-tcp-prober branch February 23, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants