Skip to content

observer: remove TCP prober #8637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beautifulentropy merged 1 commit into from
Feb 23, 2026
+1 −89
Merged

observer: remove TCP prober #8637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion observer/mon_conf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
// MonConf is exported to receive YAML configuration in `ObsConf`.
type MonConf struct {
Period config.Duration `yaml:"period"`
Kind string `yaml:"kind" validate:"required,oneof=DNS HTTP CRL TLS TCP AIA"`
Kind string `yaml:"kind" validate:"required,oneof=DNS HTTP CRL TLS AIA"`
Settings probers.Settings `yaml:"settings" validate:"min=1,dive"`
}

Expand Down
1 change: 0 additions & 1 deletion observer/observer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import (
_ "github.com/letsencrypt/boulder/observer/probers/crl"
_ "github.com/letsencrypt/boulder/observer/probers/dns"
_ "github.com/letsencrypt/boulder/observer/probers/http"
_ "github.com/letsencrypt/boulder/observer/probers/tcp"
_ "github.com/letsencrypt/boulder/observer/probers/tls"
)

Expand Down
32 changes: 0 additions & 32 deletions observer/probers/tcp/tcp.go
View file
Open in desktop

This file was deleted.

45 changes: 0 additions & 45 deletions observer/probers/tcp/tcp_conf.go
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions test/config-next/observer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,3 @@ monitors:
url: http://letsencrypt.org/foo
rcodes: [200, 404]
useragent: "letsencrypt/boulder-observer-http-client"
-
period: 10s
kind: TCP
settings:
hostport: acme-v02.api.letsencrypt.org:443
5 changes: 0 additions & 5 deletions test/config/observer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,6 @@ monitors:
url: http://letsencrypt.org/foo
rcodes: [200, 404]
useragent: "letsencrypt/boulder-observer-http-client"
-
period: 10s
kind: TCP
settings:
hostport: acme-v02.api.letsencrypt.org:443
-
period: 1h
kind: AIA
Expand Down