Open
Conversation
Contributor
marten-seemann
left a comment
There was a problem hiding this comment.
Have you considered tying a datagram flow to a stream, similar to what HTTP DATAGRAMS (RFC 9297) does?
This would have the following benefits:
- Shorter datagram header (especially important given MTU restrictions).
- Both peers get the opportunity to cancel a datagram flow (by closing / resetting the associated stream).
- A reliable control channel, e.g. for application protocols that need to send an occasional control message next to a datagram flow.
Contributor
Author
|
Thanks @marten-seemann! That's a nice idea. We can include the versioning information in the stream as well so we don't pay that overhead on every datagram. The datagram itself then only has a single varint of overhead. |
8dac785 to
1b5c110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial text for specifying how datagrams will work on libp2p.
cc @raulk @sukunrt @jxs