support running DP in circuit training#93
Open
zhuhanqing wants to merge 2 commits intolimbo018:masterfrom
Open
support running DP in circuit training#93zhuhanqing wants to merge 2 commits intolimbo018:masterfrom
zhuhanqing wants to merge 2 commits intolimbo018:masterfrom
Conversation
limbo018
reviewed
Oct 31, 2022
Owner
limbo018
left a comment
limbo018
left a comment
There was a problem hiding this comment.
Hi, sorry for the delay. I have attached review comments. Your code has been merged into a new branch called circuit_training so that it does not affect the master branch. Please try to take a look at the review comments and send a new pull request.
Contributor
Author
|
Thanks for your comments! I have sent a new pull request with all comments being addressed. |
Owner
Thank you! The other PR has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify DREAMPlace such that it can run inside circuit training.
Add a flag use_dp_for_circuit_training to isolate changes with the main logic flow.