Improve memory release with leave_room#75
Open
gfroissard wants to merge 2 commits intolivekit:mainfrom
Open
Conversation
This is to avoid use after free of que queue for example.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improve two things related of the usage of "leave_room" (function not called yet in the sample code).
Possible use after free
In some case, for example, the websocket can try to enqueue a message in a queue which has been freed but the pointer has not been set to NULL.
Possible memory leak
The event group is created by
peer_createit is now released inpeer_destroyin order to make it symmetric and avoid memory leak.