Skip to content

Improve memory release with leave_room #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gfroissard wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve memory release with leave_room #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b55ee7c
engine: Set pointer to null when resources are freed
gfroissard Feb 15, 2026
54ba12c
peer: When destroying peer destroy event group
gfroissard Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions components/livekit/core/engine.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,21 +1179,27 @@ engine_err_t engine_destroy(engine_handle_t handle)
// TODO: Wait for disconnected state or timeout
vTaskDelay(pdMS_TO_TICKS(100));
vTaskDelete(eng->task_handle);
eng->task_handle = NULL;
}
if (eng->timer != NULL) {
xTimerDelete(eng->timer, portMAX_DELAY);
eng->timer = NULL;
}
if (eng->event_queue != NULL) {
vQueueDelete(eng->event_queue);
eng->event_queue = NULL;
}
if (eng->signal_handle != NULL) {
signal_destroy(eng->signal_handle);
eng->signal_handle = NULL;
}
if (eng->pub_peer_handle != NULL) {
peer_destroy(eng->pub_peer_handle);
eng->pub_peer_handle = NULL;
}
if (eng->sub_peer_handle != NULL) {
peer_destroy(eng->sub_peer_handle);
eng->sub_peer_handle = NULL;
}
SAFE_FREE(eng->server_url);
SAFE_FREE(eng->token);
Expand Down
3 changes: 3 additions & 0 deletions components/livekit/core/peer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,9 @@ peer_err_t peer_destroy(peer_handle_t handle)
return PEER_ERR_INVALID_ARG;
}
peer_t *peer = (peer_t *)handle;
if (peer && peer->wait_event) {
media_lib_event_group_destroy(peer->wait_event);
}
free(peer);
return PEER_ERR_NONE;
}
Expand Down