[4.2.x] Fix #reconnect! method and CI config#18
Open
ziggythehamster wants to merge 9 commits intolocalytics:v4.2.xfrom
Open
[4.2.x] Fix #reconnect! method and CI config#18ziggythehamster wants to merge 9 commits intolocalytics:v4.2.xfrom
ziggythehamster wants to merge 9 commits intolocalytics:v4.2.xfrom
Conversation
…e test suite works.
… initialize in the adapter)
divoxx
pushed a commit
to doximity/odbc_adapter
that referenced
this pull request
Aug 11, 2023
…d-records-saving MOJ-225 fix associated records saving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
#reconnect!method didn't work because the configuration wasn't kept in the adapter instance. This kept the method from actually being able to rebuild a connection.Also, while I was in here, I made Travis work again after their recent changes and added a test for the connection methods that are implemented.
I have another PR incoming for backporting the v5.x
NullODBCAdapter, so don't bump any version numbers just yet :)