Add map and andThen override to RowParser #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override `andThen` to return a RowParser instead of just a A => B, and add a map function that is an alias to andThen.
jadenPete
approved these changes
Jan 21, 2025
| def apply(row: SqlRow) = parse(row) | ||
|
|
||
| override def andThen[B](g: A => B): RowParser[B] = new RowParser[B] { | ||
| def parse(row: SqlRow): B = g(self.parse(row)) |
There was a problem hiding this comment.
Nit: self.parse can be replaced with RowParser.this.parse.
Contributor
There was a problem hiding this comment.
I don't think so—the inner block we're in is also a RowParser, so I think that would just be the same as parse
There was a problem hiding this comment.
I think Scala is smart enough to realize it's different:
https://scastie.scala-lang.org/eJ4rnnv4RAC1pOtgRslsZQ
Contributor
Author
There was a problem hiding this comment.
Even if that does work, I think using the self is more clear.
coreywoodfield
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override
andThento return a RowParser instead of just a A => B, and add a map function that is an alias to andThen.