Skip to content

Add map and andThen override to RowParser #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmccombs merged 1 commit into from
Jan 21, 2025
Merged

Add map and andThen override to RowParser #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion relate/src/main/scala/com/lucidchart/relate/RowParser.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,16 @@ import java.time.Instant
import scala.collection.mutable
import scala.language.higherKinds

trait RowParser[A] extends (SqlRow => A) {
trait RowParser[A] extends (SqlRow => A) { self =>
def parse(row: SqlRow): A

def apply(row: SqlRow) = parse(row)

override def andThen[B](g: A => B): RowParser[B] = new RowParser[B] {
def parse(row: SqlRow): B = g(self.parse(row))
Copy link

@jadenPete jadenPete Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: self.parse can be replaced with RowParser.this.parse.

Copy link
Contributor

@coreywoodfield coreywoodfield Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so—the inner block we're in is also a RowParser, so I think that would just be the same as parse

Copy link

@jadenPete jadenPete Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Scala is smart enough to realize it's different:
https://scastie.scala-lang.org/eJ4rnnv4RAC1pOtgRslsZQ

Copy link
Contributor Author

@tmccombs tmccombs Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if that does work, I think using the self is more clear.

Copy link

@jadenPete jadenPete Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

}

def map[B](f: A => B): RowParser[B] = andThen(f)
}

object RowParser {
Expand Down