fix: disable MSAK client debug mode in production

[Kunal1522]

Problem

client.debug was set to true in runMSAK(), enabling verbose internal logging to the browser console for every user running a speed test. Debug output should never ship to production.

Fix

-      client.debug = true;
+      client.debug = false;

[robertodauria]

Thanks @Kunal1522!

While I agree in general, writing the test state to the console in this case was an intentional choice. Console logs are infrequent enough that they won't interfere with running tests, and I think it's reasonable to expect additional verbosity when looking at the development console.

Perhaps an alternative idea would be renaming debug to verbose in the JS library, to better reflect what it does?

[Kunal1522]

hi @robertodauria can i make a separate to rename debug to verbose in case that is not covered in #83 or should i wait for it to be merged ?

[robertodauria]

hi @robertodauria can i make a separate to rename debug to verbose in case that is not covered in #83 or should i wait for it to be merged ?

That change would need to be made to the msak-js library (https://github.com/m-lab/msak-js/blob/main/src/msak.js#L11) and be included in the next release, as the variable is defined there. After looking at what this is actually used for, however, I feel debug isn't a bad name for it. Renaming it would also definitely break existing users of the library. I would just keep it as-is. :)

[Kunal1522]

Apologies for the oversight :( I didn’t realize it was defined in msak-js . That makes sense. Thanks for the clarification.