-
Notifications
You must be signed in to change notification settings - Fork 14
📝 [maykinmedia/open-api-framework#205] Describe version policy + supported versions in documentation #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #729 +/- ##
=======================================
Coverage 84.98% 84.98%
=======================================
Files 141 141
Lines 2843 2843
Branches 224 224
=======================================
Hits 2416 2416
Misses 375 375
Partials 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5bdfc13 to
33abf75
Compare
c0ff3dd to
d6a091a
Compare
d6a091a to
febc8a9
Compare
stevenbal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you apply the same changes
fa548e9 to
b668e48
Compare
…orted versions in documentation
b668e48 to
50f0b5e
Compare
|
| Branch | feature/add-version-policy |
| Testbed | ubuntu-24.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type | 📈 view plot 🚷 view threshold | 123.20 ms(+2.64%)Baseline: 120.04 ms | 126.04 ms (97.75%) |
| performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result | 📈 view plot 🚷 view threshold | 22.31 ms(+3.93%)Baseline: 21.46 ms | 22.54 ms (98.98%) |
| performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1 | 📈 view plot 🚷 view threshold | 306.14 ms(+1.46%)Baseline: 301.74 ms | 316.83 ms (96.63%) |
| performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5 | 📈 view plot 🚷 view threshold | 305.99 ms(+1.19%)Baseline: 302.40 ms | 317.52 ms (96.37%) |
| performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20 | 📈 view plot 🚷 view threshold | 133.19 ms(+2.25%)Baseline: 130.26 ms | 136.78 ms (97.38%) |
stevenbal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor wording issue remaining, looks good otherwise.
@danielmursa-dev could you apply the same suggestions to Open Zaak and the other open PRs for this issue?
| The most recent major release is supported indefinitely and the end date of its 24-month support | ||
| period is set only once a new major release is published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's reword this slightly
| The most recent major release is supported indefinitely and the end date of its 24-month support | |
| period is set only once a new major release is published. | |
| Each major version is supported until 24 months after the release of the next major version. The most recent major version is supported without a fixed end date until a new major version is released. |
Partially closes maykinmedia/open-api-framework#205