Open
Conversation
- Add test for multiline applicationId declarations in build.gradle - Add test for spaces around equals sign in applicationId assignment - Add test to verify build.gradle applicationId takes priority over AndroidManifest.xml - Add test for missing applicationId in build.gradle with manifest fallback - Add test for empty build.gradle file handling - Add test for application name lowercase conversion - Add test for special characters in application names These tests provide comprehensive coverage for the package name resolution logic, ensuring robustness across various build.gradle and AndroidManifest.xml formats.
Refactored test suite to reduce code duplication: - Merged 3 separate format tests into parametrized test with test data - Combined 'fall back to manifest' and 'empty file' tests into one scenario - Combined default package name tests into parametrized test with multiple app names - Improved test clarity and maintainability by grouping related scenarios This reduces from 7 individual tests to 5 more focused tests while maintaining full coverage.
…unctions and consolidating duplicate tests - Extract three helper functions: setupBuildGradleStub, setupManifestStub, and resolvePackageName - Consolidate four separate build.gradle format tests into one parameterized test - Remove redundant stub setup code throughout the test suite - Simplify teardown logic by removing unnecessary null checks - Maintain 100% test coverage while reducing code from 274 to 198 lines (-27.7%) - Improve test maintainability and readability
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The test was failing on macOS CI because it only waited 2 seconds for the .vscode folder to appear in file explorer. This increases the timeout to 10 seconds using the new TimeoutConstants.FILE_EXPLORER_TIMEOUT constant.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge scattered test cases. Remove duplicate "prioritize" and "fallback" logic tests.
Remove redundant null checks.
Test coverage remains the same, but the code is more maintainable.