ci: add ARM64 Windows runner support to workflows#420
Merged
wmmc88 merged 40 commits intomicrosoft:mainfrom Aug 15, 2025
Merged
ci: add ARM64 Windows runner support to workflows#420wmmc88 merged 40 commits intomicrosoft:mainfrom
wmmc88 merged 40 commits intomicrosoft:mainfrom
Conversation
krishnakumar4a4
force-pushed
the
364-ci-workflows-with-arm-based-runners
branch
6 times, most recently
from
fb530fc to
3a4957e
Compare
krishnakumar4a4
force-pushed
the
364-ci-workflows-with-arm-based-runners
branch
4 times, most recently
from
7224cc8 to
7e82f63
Compare
krishnakumar4a4
force-pushed
the
364-ci-workflows-with-arm-based-runners
branch
10 times, most recently
from
4802fce to
3582c77
Compare
krishnakumar4a4
force-pushed
the
364-ci-workflows-with-arm-based-runners
branch
from
3582c77 to
99ced68
Compare
krishnakumar4a4
force-pushed
the
364-ci-workflows-with-arm-based-runners
branch
from
78fcfe5 to
9848ec9
Compare
wmmc88
reviewed
Aug 5, 2025
krishnakumar4a4
force-pushed
the
364-ci-workflows-with-arm-based-runners
branch
from
79f05cd to
cc923ec
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Krishna Kumar Thokala <krishna.thokala2010@gmail.com>
…d issue with 10.0.22621 kit
wmmc88
reviewed
Aug 13, 2025
Collaborator
wmmc88
left a comment
wmmc88
left a comment
There was a problem hiding this comment.
im still seeing if there is something to be done about SDK. I've reached out to folks who own it and they're looking into it. rather than download the exe, i've also got winget to install it properly via --override
gurry
reviewed
Aug 13, 2025
gurry
reviewed
Aug 13, 2025
krishnakumar4a4
commented
Aug 13, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for ARM64 Windows runners to the CI workflows by introducing dual-architecture build matrices. The changes enable builds and tests to run on both x64 (windows-latest) and ARM64 (windows-11-arm) runners while addressing compatibility issues specific to ARM64 environments.
Key changes include:
- Added ARM64 Windows runner support across all CI workflows (build, test, lint, docs, CodeQL, local-development-makefile)
- Refactored GitHub Actions to use dedicated actions for winget and LLVM installation
- Simplified matrix configurations by removing cross-compilation support in favor of native builds
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/test.yaml |
Added ARM64 runner matrix and removed cross-compilation target_triple |
.github/workflows/local-development-makefile.yaml |
Added ARM64 runner support and simplified Rust toolchain installation |
.github/workflows/lint.yaml |
Added ARM64 runner matrix with architecture-aware host configuration |
.github/workflows/docs.yaml |
Added ARM64 runner support and removed target-specific doc generation condition |
.github/workflows/codeql.yaml |
Updated to use new winget action and corrected host architecture value |
.github/workflows/build.yaml |
Added ARM64 runner matrix and updated comment reference |
.github/actions/winget-install/action.yaml |
Removed old winget installation action |
.github/actions/install-winget/action.yaml |
New architecture-aware winget installation action |
.github/actions/install-wdk/action.yml |
Enhanced with better error handling and SDK installation |
.github/actions/install-llvm/action.yml |
New dedicated LLVM installation action with error handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
wmmc88
requested changes
Aug 13, 2025
Collaborator
wmmc88
left a comment
wmmc88
left a comment
There was a problem hiding this comment.
Just one last issue which would mask failures (that ive already previously seen in CI runs. After this i think its good to go
wmmc88
approved these changes
Aug 13, 2025
gurry
reviewed
Aug 14, 2025
gurry
approved these changes
Aug 14, 2025
svasista-ms
approved these changes
Aug 14, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 14, 2025
Signed-off-by: Krishna Kumar Thokala <krishna.thokala2010@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Gurinder Singh <frederick.the.fool@gmail.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
target_triplefrom the matrix, as cross-compilation wouldn't work.