feat(allow_hosts): add support for hostname resolution #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@miketheman Can you re-run the test? There was some unrelated issue |
miketheman
requested changes
Feb 1, 2023
|
Code Climate has analyzed commit 0c429c0 and detected 0 issues on this pull request. View more on Code Climate. |
miketheman
approved these changes
Feb 2, 2023
Owner
miketheman
left a comment
miketheman
left a comment
There was a problem hiding this comment.
Thanks for updating! I'll merge now, and release either later this week or next.
Contributor
|
Awesome to see this implemented 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is equivalent to #80 but brought up to date with
main. This is necessary when usingdocker-composeto avoid having to assign static IPs to specific services.