Skip to content

Conversation

@Jguer
Copy link
Contributor

@Jguer Jguer commented Nov 5, 2021

Hey, thanks for the nice project.

Scenario I'm attempting to solve:

  • We have a service in our project we must connect to from a docker-composed application.
  • The hostname is stable but not the IP address.

Somewhat similar to #73

What does this MR do

  • Resolve allowed hostnames into IPs if possible and check if added exceptions are correct IPv4 addresses
  • Strip strings added to the list to make sure pytest --allow-hosts="172.18.0.2, 172.18.0.1" works

Questions

  • no checks for IPv6 addresses was done, is it relevant to readd?

If type hinting is necessary or some documentation needs to be changed feel free to ask.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit ee08d8e and detected 0 issues on this pull request.

View more on Code Climate.

@miketheman miketheman added the more-info-needed Further information is requested label Dec 23, 2021
@tonycosentini
Copy link

Any way this can get into a release? I think it would help a lot if you want to use this plugin with something like docker-compose.

@mgaitan
Copy link
Contributor

mgaitan commented Jan 9, 2023

please, could we upgrade this PR and #73 and get them into a release? I could help if you give me instructions.

@miketheman
Copy link
Owner

Closed via #189

@miketheman miketheman closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

more-info-needed Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants