feat(cli): implement backend connections for CLI commands by mugiwaraluffy56 · Pull Request #148 · mofa-org/mofa

mugiwaraluffy56 · 2026-02-21T07:50:12Z

Closes #146

The CLI had 14 command stubs that returned hardcoded example data instead of talking to the actual backend. This PR replaces all of them with real integrations.

Added a CliContext struct that initializes SessionManager, AgentRegistry, SimplePluginRegistry, and ToolRegistry. Made the command dispatch async so everything can call the backend APIs properly.

Session commands now use SessionManager with file based persistence under ~/.local/share/mofa/sessions. The delete command also has a proper confirmation prompt now.

Agent commands use the AgentRegistry from mofa-runtime for lifecycle management. Start loads config via ConfigLoader, stop does graceful shutdown, restart calls stop then start, and list/status query the registry.

Plugin and tool commands query their respective registries and display real metadata instead of fake placeholder data.

All 16 CLI tests pass and the build compiles cleanly.

Closes mofa-org#146

Copilot

Pull request overview

This PR implements backend connections for 14 CLI command stubs that previously returned hardcoded placeholder data. It introduces a CliContext struct that initializes and provides access to backend services (SessionManager, AgentRegistry, SimplePluginRegistry, and ToolRegistry), and converts the command dispatch to async to support calling backend APIs.

Changes:

Introduced CliContext struct with SessionManager (file-based persistence) and in-memory registries for agents, plugins, and tools
Converted command dispatch to async with conditional context initialization
Implemented real backend integrations for session, agent, plugin, and tool commands

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
crates/mofa-cli/src/main.rs	Added async runtime, CliContext initialization, and updated command routing to async
crates/mofa-cli/src/context.rs	New file defining CliContext with backend service initialization
crates/mofa-cli/src/commands/agent/start.rs	Implemented agent starting with config loading and registry registration
crates/mofa-cli/src/commands/agent/stop.rs	Implemented graceful agent shutdown and registry unregistration
crates/mofa-cli/src/commands/agent/restart.rs	Implemented agent restart by calling stop then start
crates/mofa-cli/src/commands/agent/list.rs	Implemented agent listing from registry with filtering
crates/mofa-cli/src/commands/agent/status.rs	Implemented agent status retrieval from registry metadata
crates/mofa-cli/src/commands/plugin/list.rs	Implemented plugin listing from registry
crates/mofa-cli/src/commands/plugin/info.rs	Implemented plugin info retrieval from registry
crates/mofa-cli/src/commands/plugin/uninstall.rs	Implemented plugin uninstallation with confirmation
crates/mofa-cli/src/commands/tool/list.rs	Implemented tool listing from registry with source information
crates/mofa-cli/src/commands/tool/info.rs	Implemented tool info retrieval with metadata display
crates/mofa-cli/src/commands/session/list.rs	Implemented session listing with filtering and metadata
crates/mofa-cli/src/commands/session/show.rs	Implemented session detail display in multiple formats
crates/mofa-cli/src/commands/session/export.rs	Implemented session export to JSON/YAML files
crates/mofa-cli/src/commands/session/delete.rs	Implemented session deletion with confirmation prompt
crates/mofa-cli/Cargo.toml	Added dependencies for mofa-runtime, mofa-foundation, async-trait, and chrono

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-21T09:43:26Z

crates/mofa-cli/src/context.rs

+        let sessions_dir = data_dir.join("sessions");
+        let session_manager = SessionManager::with_jsonl(&sessions_dir)


There's a path construction issue here. The context passes data_dir.join("sessions") as the workspace path, but JsonlSessionStorage::new in the SessionManager implementation also appends "sessions" to the workspace path (see mofa-foundation/src/agent/session.rs:137). This results in the actual sessions directory being ~/.local/share/mofa/sessions/sessions instead of the intended ~/.local/share/mofa/sessions. Either remove the "sessions" suffix here and pass just data_dir, or ensure that JsonlSessionStorage::new doesn't append "sessions" again.

Suggested change

let sessions_dir = data_dir.join("sessions");

let session_manager = SessionManager::with_jsonl(&sessions_dir)

let session_manager = SessionManager::with_jsonl(&data_dir)

Copilot · 2026-02-21T09:43:27Z

crates/mofa-cli/src/commands/agent/start.rs

+    ctx: &CliContext,
+    agent_id: &str,
+    config_path: Option<&std::path::Path>,
+    daemon: bool,


The daemon parameter is accepted but not implemented in the function body. It is only used for printing a message on line 17, but the actual daemon mode functionality (backgrounding the process, proper daemon setup, etc.) is not implemented. Consider either implementing daemon mode or removing this parameter until the feature is ready.

Copilot · 2026-02-21T09:43:27Z

crates/mofa-cli/src/commands/agent/start.rs

+        println!("  Agent config stored for: {}", agent_config.name.cyan());
+    } else {
+        // Try to create via factory
+        let type_id = factory_types.first().unwrap();


Using unwrap() here is technically safe since factory_types.is_empty() was already checked in the if condition, but it's not idiomatic. Consider using pattern matching or a more explicit approach to avoid unwrap in production code. For example, you could use let type_id = &factory_types[0]; or restructure to avoid the unwrap entirely.

Suggested change

let type_id = factory_types.first().unwrap();

let type_id = &factory_types[0];

Copilot · 2026-02-21T09:43:27Z

crates/mofa-cli/src/main.rs

-            cli::AgentCommands::List { running, all } => {
-                commands::agent::list::run(running, all)?;
+        Some(Commands::Agent(agent_cmd)) => {
+            let ctx = ctx.as_ref().unwrap();


Using unwrap() on ctx.as_ref() is technically safe here because the needs_context check on line 45 ensures that ctx is Some for all Agent commands. However, this pattern is not idiomatic and could be fragile if the logic changes in the future. Consider refactoring to avoid unwrap, perhaps by handling the context requirement more explicitly or using pattern matching that makes the safety more obvious to readers and the compiler.

Suggested change

let ctx = ctx.as_ref().unwrap();

let Some(ctx) = ctx.as_ref() else {

eprintln!(

"Internal error: context is missing for Agent command. This should never happen."

);

std::process::exit(1);

};

Copilot · 2026-02-21T09:43:27Z

crates/mofa-cli/src/commands/session/list.rs

+    let mut sessions = Vec::new();
+    for key in &keys {
+        let session = ctx.session_manager.get_or_create(key).await;
+
+        // Filter by agent_id if provided (check metadata or key prefix)
+        if let Some(agent) = agent_id {
+            let matches = session
+                .metadata
+                .get("agent_id")
+                .and_then(|v| v.as_str())
+                .map(|v| v == agent)
+                .unwrap_or_else(|| session.key.contains(agent));
+            if !matches {
+                continue;
+            }
+        }


Performance concern: This code loads all sessions from storage before filtering by agent_id. For large numbers of sessions, this could be inefficient as it requires deserializing every session. While the current Session structure doesn't allow filtering without loading the full session data, consider whether this approach will scale well. You might want to add a note or TODO about potential optimization strategies (e.g., maintaining an index of session metadata).

Copilot · 2026-02-21T09:43:27Z

crates/mofa-cli/src/commands/tool/list.rs

+pub async fn run(ctx: &CliContext, _available: bool, _enabled: bool) -> anyhow::Result<()> {
    println!("{} Listing tools", "→".green());


The available and enabled parameters are accepted via the CLI but not implemented in this function. The old placeholder code had filtering logic based on these flags. Consider either implementing the filtering functionality (if the ToolRegistry supports these concepts) or documenting why these parameters are currently ignored. Users may expect the --enabled flag to filter tools, which would be a regression from the previous behavior.

Suggested change

pub async fn run(ctx: &CliContext, _available: bool, _enabled: bool) -> anyhow::Result<()> {

println!("{} Listing tools", "→".green());

pub async fn run(ctx: &CliContext, available: bool, enabled: bool) -> anyhow::Result<()> {

println!("{} Listing tools", "→".green());

if available || enabled {

println!(" Note: --available/--enabled filtering is not yet implemented; listing all tools.");

}

Copilot · 2026-02-21T09:43:28Z

crates/mofa-cli/src/commands/plugin/list.rs


 /// Execute the `mofa plugin list` command
-pub fn run(installed_only: bool, available: bool) -> anyhow::Result<()> {
+pub async fn run(ctx: &CliContext, _installed_only: bool, _available: bool) -> anyhow::Result<()> {


The installed_only and available parameters are accepted via the CLI but not implemented in this function. The old placeholder code had filtering logic based on the installed flag. Consider either implementing the filtering functionality (if the PluginRegistry supports tracking installation state) or documenting why these parameters are currently ignored. Users may expect the --installed flag to filter plugins, which would be a regression from the previous behavior.

Copilot · 2026-02-21T09:43:28Z

crates/mofa-cli/src/context.rs

+            agent_registry: AgentRegistry::new(),
+            plugin_registry: Arc::new(SimplePluginRegistry::new()),
+            tool_registry: ToolRegistry::new(),


The agent_registry, plugin_registry, and tool_registry are all in-memory and will not persist across CLI invocations. This means that agents started with mofa agent start will not be visible when running mofa agent list in a separate CLI invocation, and similarly for plugins and tools. This significantly limits the usefulness of these commands. Consider either: 1) implementing persistence for these registries (similar to session_manager), 2) clearly documenting this limitation in user-facing documentation, or 3) rethinking the agent lifecycle management approach for the CLI context.

feat(cli): wire up CLI command stubs to backend services

b465c44

Closes mofa-org#146

BH3GEI requested a review from Copilot February 21, 2026 09:37

Copilot started reviewing on behalf of BH3GEI February 21, 2026 09:37 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

mugiwaraluffy56 mentioned this pull request Feb 21, 2026

feature(cli): Implement missing backend connections for CLI commands #146

Closed

lijingrs merged commit 99c4c4b into mofa-org:main Feb 22, 2026
4 of 16 checks passed

mugiwaraluffy56 deleted the feature/issue-146-cli-backend branch February 22, 2026 04:34

This was referenced Feb 22, 2026

feat(cli): implement backend wiring for agent/plugin/session/tool commands #154

Closed

Revert "feat(cli): implement backend connections for CLI commands" #218

Closed

feat(cli): rebased backend command wiring fix for #146 #219

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat(cli): implement backend connections for CLI commands#148

feat(cli): implement backend connections for CLI commands#148
lijingrs merged 1 commit intomofa-org:mainfrom
mugiwaraluffy56:feature/issue-146-cli-backend

mugiwaraluffy56 commented Feb 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Copilot AI Feb 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		let sessions_dir = data_dir.join("sessions");
		let session_manager = SessionManager::with_jsonl(&sessions_dir)

	let type_id = factory_types.first().unwrap();
	let type_id = &factory_types[0];

-            let ctx = ctx.as_ref().unwrap();
+            let Some(ctx) = ctx.as_ref() else {
+                eprintln!(
+                    "Internal error: context is missing for Agent command. This should never happen."
+                );
+                std::process::exit(1);
+            };

		pub async fn run(ctx: &CliContext, _available: bool, _enabled: bool) -> anyhow::Result<()> {
		println!("{} Listing tools", "→".green());

Comments

Conversation

mugiwaraluffy56 commented Feb 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants