This repository was archived by the owner on Feb 4, 2021. It is now read-only.
Set up ESLint on Travis. #64
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdboom
suggested changes
Feb 13, 2018
| @@ -0,0 +1,19 @@ | |||
| { | |||
| "env": { | |||
| "browser": true | |||
Contributor
There was a problem hiding this comment.
By adding:
"amd": true,
"jquery": true
here, I was able to get this down to only legitimate errors.
201:21 error Unexpected console statement no-console
224:31 error 'textStatus' is defined but never used no-unused-vars
295:13 error 'nb_path' is assigned a value but never used no-unused-vars
341:13 error 'button_td' is not defined no-undef
344:29 error 'button_td' is not defined no-undef
345:24 error 'button_td' is not defined no-undef
352:13 error 'row_message' is not defined no-undef
353:13 error 'row_message' is not defined no-undef
354:24 error 'row_message' is not defined no-undef
Contributor
Author
There was a problem hiding this comment.
Aha, nice, thanks :)
| // resource path | ||
| "(?:[/?#]\\S*)?" + | ||
| "$", "i" | ||
| ); |
Contributor
There was a problem hiding this comment.
Maybe this improvement to URL validation should be moved to a separate pull request?
Contributor
Author
There was a problem hiding this comment.
Yeah, this was totally just to figure out if that gets the number of errors down.
Contributor
Author
|
@mdboom Yeah, that makse sense, just wanted to figure out how this would work with Travis in general, since it by design doesn't support multi-language environments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another Travis environment to install ESLint and run it. Will need to dive into more how ESLint is configured to get this fixed for the Jupyter AMD modules.