Skip to content
This repository was archived by the owner on Feb 4, 2021. It is now read-only.

Set up ESLint on Travis. #64

Open
jezdez wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Set up ESLint on Travis. #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7972d53
Add eslint.
jezdez Feb 13, 2018
0dbd363
Improved setup.
jezdez Feb 13, 2018
088e475
Minor fix?
jezdez Feb 13, 2018
680f921
Use saner URL validation.
jezdez Feb 13, 2018
6adb58a
Add NPM cache.
jezdez Feb 13, 2018
89a6b5f
Add NPM cache.
jezdez Feb 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"env": {
"browser": true
Copy link
Contributor

@mdboom mdboom Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By adding:

"amd": true,
"jquery": true

here, I was able to get this down to only legitimate errors.

  201:21  error  Unexpected console statement                  no-console
  224:31  error  'textStatus' is defined but never used        no-unused-vars
  295:13  error  'nb_path' is assigned a value but never used  no-unused-vars
  341:13  error  'button_td' is not defined                    no-undef
  344:29  error  'button_td' is not defined                    no-undef
  345:24  error  'button_td' is not defined                    no-undef
  352:13  error  'row_message' is not defined                  no-undef
  353:13  error  'row_message' is not defined                  no-undef
  354:24  error  'row_message' is not defined                  no-undef

Copy link
Contributor Author

@jezdez jezdez Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, nice, thanks :)

},
"plugins": [
"amd-imports"
],
"extends": "eslint:recommended",
"rules": {
"indent": [
"error",
4
],
"linebreak-style": [
"error",
"unix"
]
}
}
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,5 @@ target/

#Ipython Notebook
.ipynb_checkpoints

node_modules/
14 changes: 14 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,18 @@ python:
- 3.5
- 3.6
- pypy
matrix:
include:
- env: eslint
sudo: false
cache:
directories:
- node_modules # NPM packages
install:
- nvm install 8
- npm install
script:
- node ./node_modules/eslint/bin/eslint.js --ext .js src/jupyter_notebook_gist/static
sudo: false
cache: pip
install:
Expand All @@ -13,3 +25,5 @@ script:
- tox -v -e py
after_success:
- codecov
allow_failures:
- env: eslint
Loading