Merged
Conversation
…public in FieldPosition for easy access and standardize to radians to match our conventions, add Localizer interface, update MecanumDriver for standardization to radians in FieldPosition, add MoveToAction
Closed
Contributor
Author
|
build fails due to missing PID |
AncientBison
requested changes
Aug 7, 2025
added 2 commits
August 7, 2025 00:29
…method of FieldPosition, fix return type of init method in Localizer, turn PID coefficients into a class (PIDCoefficients) and adjust comments
…e to use of this in MoveToAction
AncientBison
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create MoveToAction, and also the basic Localizer interface
PID is missing