Fixes issue with deprecated info.Holder() in latest version of V8. Adds support for Node.js 23 and 24 tests. #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Sorry, but you need to do a |
Contributor
Author
|
To be honest not entirely sure how to do that or what that even means, will try to figure it out later. |
Collaborator
|
Don't worry. I'll see what I can do tomorrow.
…On June 26, 2025 11:47:59 PM GMT+03:00, agracio ***@***.***> wrote:
agracio left a comment (nodejs/nan#1001)
To be honest not entirely sure how to do that or what that even means, will try to figure that out later.
--
Reply to this email directly or view it on GitHub:
#1001 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
Contributor
Author
|
Any updates, or should we just leave nan for node.js 24 broken? |
Contributor
Author
@kkoopa pinging you directly as I am not sure if you read all messages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging #1000 to node23 branch.