Skip to content

Fixes issue with deprecated info.Holder() in latest version of V8. Adds support for Node.js 23 and 24 tests. #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agracio wants to merge 10 commits into from
Closed

Fixes issue with deprecated info.Holder() in latest version of V8. Adds support for Node.js 23 and 24 tests. #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f88eb2c
merging https://github.com/nodejs/nan/pull/979
agracio Jun 17, 2025
fa3d61e
updating tests
agracio Jun 17, 2025
f99f297
reverting CI changes
agracio Jun 17, 2025
d926d1a
updating CI
agracio Jun 17, 2025
1dcbe3c
removing unnecessary files
agracio Jun 17, 2025
55c22bc
fixing duplicate method declaration
agracio Jun 17, 2025
e419f50
Merge branch 'node23' into main
agracio Jun 26, 2025
0bc2dc1
fixing incorrect merge
agracio Jul 3, 2025
a91d752
Merge branch 'main' of https://github.com/agracio/nan
agracio Jul 3, 2025
4eea5e9
Merge branch 'node23' into main
agracio Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nan_callbacks.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ namespace Intercepted {
};
#else
namespace Intercepted {
inline void No() {}
inline void Yes() {}
inline void No() {}
inline void Yes() {}
};
#endif

Expand Down
1 change: 1 addition & 0 deletions nan_callbacks_12_inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ class FunctionCallbackInfo {
}

#if NODE_MAJOR_VERSION < 10

NAN_DEPRECATED inline v8::Local<v8::Function> Callee() const {
return info_.Callee();
}
Expand Down
4 changes: 2 additions & 2 deletions test/js/methodswithdata-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ const test = require('tap').test
const nodeVersion = parseInt(process.versions.node.split('.')[0]);

test('SetMethod with data', function (t) {
t.plan(1);
t.ok(bindings.testWithData());
t.plan(1);
t.ok(bindings.testWithData());
});

test('accessors with data', function (t) {
Expand Down