Skip to content

Remove legacy handler wrappers #4786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mcollina wants to merge 16 commits into
base: next
Choose a base branch
from
Open

Remove legacy handler wrappers #4786

mcollina wants to merge 16 commits into from
+1,750 −9,876

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Jan 30, 2026

Summary

  • fix raw header handling in cache/decompress interceptors
  • add shared toRawHeaders utility
  • update snapshot replay raw headers
  • bulk of the v8 version change

Testing

  • npm test

@mcollina
Copy link
Member Author

mcollina commented Jan 30, 2026

I used AI for this, so review with caution

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 95.01312% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.25%. Comparing base (4b36fef) to head (653d513).
⚠️ Report is 2 commits behind head on next.

Files with missing lines Patch % Lines
lib/interceptor/cache.js 73.33% 8 Missing ⚠️
lib/interceptor/decompress.js 74.07% 7 Missing ⚠️
lib/mock/snapshot-agent.js 85.71% 2 Missing ⚠️
lib/mock/mock-utils.js 95.23% 1 Missing ⚠️
lib/web/fetch/index.js 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #4786   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files         109      107    -2     
  Lines       34001    34031   +30     
=======================================
+ Hits        31708    31736   +28     
- Misses       2293     2295    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina added the semver-major Features or fixes that will be included in the next semver major release label Jan 31, 2026
This was referenced Feb 2, 2026
Open
Open
@mcollina
Drop support for Node.js 20
653d513 
BREAKING CHANGE: Node.js 20 is no longer supported. Minimum Node.js version is now 22.

Changes:
- Update engines field in package.json to >=22.0.0
- Remove Node 20 from CI test matrix
- Add Node 22 to WASM SIMD disabled test matrix
- Simplify cache-interceptor test to always use sqlite
- Update @types/node to ^22.0.0
@hexchain
Copy link
Contributor

hexchain commented Feb 4, 2026

This should also fix #4389.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronag ronag ronag approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

Assignees

No one assigned

Labels

semver-major Features or fixes that will be included in the next semver major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mcollina @codecov-commenter @hexchain @ronag @metcoder95